Drop test that's waiting for a bug fix in goyaml

Drop test that's waiting for a bug fix in goyaml

With r39 of lp:goyaml, Gustavo has fixed both bugs https://bugs.launchpad.net/juju-core/+bug/1132537 and https://bugs.launchpad.net/goyaml/+bug/1133337.

So, a test added to juju-core to watch for when bug 1132537 is fixed now fails and needs to be removed (as it advises itself).  A test that makes sure that unmarshalling "" to *string works is reinstanted.

https://code.launchpad.net/~danilo/juju-core/bug-1132537/+merge/157860

(do not edit description out of merge proposal)

[Danilo, 2013-04-09 13:31:30]

Please take a look.

[dimitern, 2013-04-09 13:40:48]

LGTM, provided you tested this properly with the tip revisions of both juju-core
and goyaml.

[TheMue, 2013-04-09 13:53:55]

LGTM, but as Dimiter stated it has to be tested with top of both, juju-core and
goyaml. "go get -u ..." has to retrieve the fixed goyaml package.

[Danilo, 2013-04-09 13:58:14]

Thanks for the reviews.

I've tested it (as in, ran the tests) with both lp:goyaml r38 and r39 (latest)
and lp:juju-core tip. Do I need to do anything else before I "lbox submit"?

Will the lbox check handler run the test suite for me again?

[dimitern, 2013-04-09 14:00:43]

On 2013/04/09 13:58:14, danilo.segan wrote:
> Thanks for the reviews.
> 
> I've tested it (as in, ran the tests) with both lp:goyaml r38 and r39 (latest)
> and lp:juju-core tip. Do I need to do anything else before I "lbox submit"?
> 
> Will the lbox check handler run the test suite for me again?

Probably it's a good idea to pull trunk, and merge it in this branch.
Make sure you run "go build ./... && go test ./..." in juju-core/
Then just lbox submit. I usually also close the CL here on rietveld (for my own
sake, to filter them a bit). Then I usually switch to trunk, pull and run the
same again to make sure nothing bad happened.

[TheMue, 2013-04-09 14:07:14]

On 2013/04/09 14:00:43, dimitern wrote:
> On 2013/04/09 13:58:14, danilo.segan wrote:
> > Thanks for the reviews.
> > 
> > I've tested it (as in, ran the tests) with both lp:goyaml r38 and r39
(latest)
> > and lp:juju-core tip. Do I need to do anything else before I "lbox submit"?
> > 
> > Will the lbox check handler run the test suite for me again?
> 
> Probably it's a good idea to pull trunk, and merge it in this branch.
> Make sure you run "go build ./... && go test ./..." in juju-core/
> Then just lbox submit. I usually also close the CL here on rietveld (for my
own
> sake, to filter them a bit). Then I usually switch to trunk, pull and run the
> same again to make sure nothing bad happened.

I can only repeat this. Merging the trunk, doing a complete build and test is
very important. A continuous integration also running the tests is not yet
setup.

[Danilo, 2013-04-09 14:28:38]

*** Submitted:

Drop test that's waiting for a bug fix in goyaml

With r39 of lp:goyaml, Gustavo has fixed both bugs
https://bugs.launchpad.net/juju-core/+bug/1132537 and
https://bugs.launchpad.net/goyaml/+bug/1133337.

So, a test added to juju-core to watch for when bug 1132537 is fixed now fails
and needs to be removed (as it advises itself).  A test that makes sure that
unmarshalling "" to *string works is reinstanted.

R=dimitern, TheMue
CC=
https://codereview.appspot.com/8572043