worker/uniter: startup with correct relation state

worker/uniter: startup with correct relation state

The uniter's runListener is not started until after relation state is set
up; and relation state setup is fixed to use true relation state from the
API server rather than the local best guess, which is inaccurate when any
joined relation has never seen a remote unit.

This involves a new API, which the unit agent will wait for, in case it
connects to an API server which hasn't yet been upgraded.

https://code.launchpad.net/~fwereade/juju-core/uniter-relation-states/+merge/215003

(do not edit description out of merge proposal)

[fwereade, 2014-04-09 17:37:00]

Please take a look.

[hduran, 2014-04-09 17:47:10]

https://codereview.appspot.com/85670046/diff/1/state/api/uniter/unit.go
File state/api/uniter/unit.go (right):

https://codereview.appspot.com/85670046/diff/1/state/api/uniter/unit.go#newco...
state/api/uniter/unit.go:445: return nil, fmt.Errorf("expected one result, got
%d", len(results.Results))
This is purely aesthetic and not sure if valid for English but if got %d prints
a number, "one" should also be a number.

[jameinel, 2014-04-09 22:19:27]

LGTM, though mostly from matching the code to your description of what it is
doing.

[fwereade, 2014-04-10 12:48:54]

https://codereview.appspot.com/85670046/diff/1/state/api/uniter/unit.go
File state/api/uniter/unit.go (right):

https://codereview.appspot.com/85670046/diff/1/state/api/uniter/unit.go#newco...
state/api/uniter/unit.go:445: return nil, fmt.Errorf("expected one result, got
%d", len(results.Results))
On 2014/04/09 17:47:11, hduran wrote:
> This is purely aesthetic and not sure if valid for English but if got %d
prints
> a number, "one" should also be a number. 

FWIW, style guides I've seen have suggested that you should always spell out
numbers below N, for varying N. Being consistent works for me though; done.