Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 85450044: cmd/jujud: upgradeWorker opens state

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by rog
Modified:
5 years, 10 months ago
Reviewers:
dimitern, mp+214798, gz
Visibility:
Public.

Description

cmd/jujud: upgradeWorker opens state The scheme that this replaces makes an unwarrantedly chummy relationship between APIWorker and StateWorker. (and it panicked when StateWorker was invoked more than once). We fix it by making an independent connection to the state for the upgrader's needs. We also refactor some of the testing code to move as much test-related logic out of the production code as possible and to merge some duplicated code. https://code.launchpad.net/~rogpeppe/juju-core/541-upgrader-independent-state-open/+merge/214798 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: upgradeWorker opens state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -90 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/machine.go View 9 chunks +46 lines, -54 lines 0 comments Download
M cmd/jujud/machine_test.go View 3 chunks +38 lines, -36 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
5 years, 10 months ago (2014-04-08 15:46:48 UTC) #1
dimitern
LGTM
5 years, 10 months ago (2014-04-08 15:59:11 UTC) #2
gz
5 years, 10 months ago (2014-04-08 15:59:48 UTC) #3
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b