code review 8544043: go-tour: implements full screen width on slides without...

go-tour: implements full screen width on slides without the embedded playground.

See: https://groups.google.com/forum/?fromgroups=#!topic/golang-nuts/3C0au28yAGA

[nickp, 2013-04-09 00:28:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go-tour/

[adg, 2013-04-09 02:51:12]

https://codereview.appspot.com/8544043/diff/5001/js/tour.js
File js/tour.js (right):

https://codereview.appspot.com/8544043/diff/5001/js/tour.js#newcode11
js/tour.js:11: var $wrap;
delete

https://codereview.appspot.com/8544043/diff/5001/js/tour.js#newcode29
js/tour.js:29: $wrap = $("#wrap");
delete (jquery caches these lookups anyway)

https://codereview.appspot.com/8544043/diff/5001/js/tour.js#newcode200
js/tour.js:200: $wrap.addClass("full-width");
$('#wrap').addClass('full-width');

https://codereview.appspot.com/8544043/diff/5001/js/tour.js#newcode202
js/tour.js:202: $wrap.removeClass("full-width");
$('#wrap').removeClass('full-width');

[nickp, 2013-04-09 02:58:23]

Hello golang-dev@googlegroups.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2013-04-09 03:03:10]

LGTM

Great, thanks.

[adg, 2013-04-09 03:04:29]

Can you please sign the CLA as per
http://golang.org/doc/contribute.html#Copyright ?


On 9 April 2013 12:58, <nick1presta@gmail.com> wrote:

> Hello golang-dev@googlegroups.com, adg@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
https://codereview.appspot.**com/8544043/<https://codereview.appspot.com/8544...
>

[nickp, 2013-04-09 03:08:03]

I did -- I signed it as nick@nickpresta.ca. I just resigned it as
nick1presta@gmail.com

Thanks!

On 2013/04/09 03:04:29, adg wrote:
> Can you please sign the CLA as per
> http://golang.org/doc/contribute.html#Copyright ?
> 
> 
> On 9 April 2013 12:58, <mailto:nick1presta@gmail.com> wrote:
> 
> > Hello mailto:golang-dev@googlegroups.com, mailto:adg@golang.org (cc:
> > mailto:golang-dev@googlegroups.com),
> >
> > Please take another look.
> >
> >
> >
>
https://codereview.appspot.**com/8544043/%3Chttps://codereview.appspot.com/85...>
> >

[adg, 2013-04-09 03:12:05]

On 9 April 2013 13:08, <nick1presta@gmail.com> wrote:

> I did -- I signed it as nick@nickpresta.ca. I just resigned it as
> nick1presta@gmail.com
>

Ah, ok. Thanks.

[adg, 2013-04-09 03:13:18]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=f49c09fb38a8
***

go-tour: implements full screen width on slides without the embedded playground.

See: https://groups.google.com/forum/?fromgroups=#!topic/golang-nuts/3C0au28yAGA

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/8544043

Committer: Andrew Gerrand <adg@golang.org>