Issue 8529043: Updates charm container design

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8529043: Updates charm container design

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by j.c.sackett

Modified:
11 years ago

Reviewers:
rharding, jeff.pihach, mp+157745

Visibility:
Public.

Description

Updates charm container design -Updates template to use new expand/collapse design (arrows, no text) and show total charm count in title -renderUI now assembles template data, rather than adding more ATTRS and using a one off template helper -hasExtra template helper is removed -Updated tests https://code.launchpad.net/~jcsackett/juju-gui/charm-container-redesign/+merge/157745 Requires: https://code.launchpad.net/~jcsackett/juju-gui/helpers-and-friends/+merge/157560 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updates charm container design #

Patch Set 3 : Updates charm container design #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -21 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/templates/charm-container.handlebars	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	app/widgets/charm-container.js	View	1 2	2 chunks	+7 lines, -12 lines	0 comments	Download
M	test/test_charm_container.js	View	1 2	4 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rharding

LGTM with one trivial. https://codereview.appspot.com/8529043/diff/1/app/widgets/charm-container.js File app/widgets/charm-container.js (right): https://codereview.appspot.com/8529043/diff/1/app/widgets/charm-container.js#newcode130 app/widgets/charm-container.js:130: content = this.TEMPLATE(data), this alignment ...

11 years ago (2013-04-08 20:46:04 UTC) #2

j.c.sackett

https://codereview.appspot.com/8529043/diff/1/app/widgets/charm-container.js File app/widgets/charm-container.js (right): https://codereview.appspot.com/8529043/diff/1/app/widgets/charm-container.js#newcode130 app/widgets/charm-container.js:130: content = this.TEMPLATE(data), On 2013/04/08 20:46:04, rharding wrote: > ...

11 years ago (2013-04-08 20:48:05 UTC) #3

j.c.sackett

11 years ago (2013-04-09 13:35:01 UTC) #6

*** Submitted:

Updates charm container design

-Updates template to use new expand/collapse design (arrows, no text) and show
total charm count in title
-renderUI now assembles template data, rather than adding more ATTRS and using
a one off template helper
-hasExtra template helper is removed
-Updated tests

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/8529043

Expand All Messages | Collapse All Messages