Issue 8510043: state: use one schema for status

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8510043: state: use one schema for status

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rog

Modified:
11 years ago

Reviewers:
mp+157609, dimitern, fwereade

Visibility:
Public.

Description

state: use one schema for status When implementing the allWatcher, it helps to have a single doc type per collection. https://code.launchpad.net/~rogpeppe/juju-core/272-state-status-one-schema/+merge/157609 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: use one schema for status #

Total comments: 4

Patch Set 3 : state: use one schema for status #

Patch Set 4 : state: use one schema for status #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -40 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/machine.go	View	1 2	2 chunks	+11 lines, -14 lines	0 comments	Download
M	state/service.go	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	state/state.go	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download
M	state/status.go	View	1 2	1 chunk	+19 lines, -9 lines	0 comments	Download
M	state/unit.go	View	1 2	3 chunks	+9 lines, -13 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

LGTM modulo some trivials. Also I think you should delete unitStatusDoc and machineStatusDoc definitions from ...

11 years ago (2013-04-08 09:45:36 UTC) #2

rog

Please take a look. https://codereview.appspot.com/8510043/diff/2001/state/machine.go File state/machine.go (right): https://codereview.appspot.com/8510043/diff/2001/state/machine.go#newcode481 state/machine.go:481: status = params.MachineStatus(doc.Status) On 2013/04/08 ...

11 years ago (2013-04-08 10:13:58 UTC) #3

rog

11 years ago (2013-04-08 22:34:14 UTC) #5

*** Submitted:

state: use one schema for status

When implementing the allWatcher, it helps
to have a single doc type per collection.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/8510043

Expand All Messages | Collapse All Messages