Adds template helpers e.g. for pluralization.

Adds template helpers e.g. for pluralization.

-Adds a pluralize template helper for pluralizing words based on
length or size of an object or number passed in.
-Adds a helper to handle the "no extra items" case for charm container, rather
than an otherwise awkward attribute.
-Adds tests
-Updates code and templates.

https://code.launchpad.net/~jcsackett/juju-gui/helpers-and-friends/+merge/157560

(do not edit description out of merge proposal)

[j.c.sackett, 2013-04-07 19:37:48]

Please take a look.

[rharding, 2013-04-07 19:59:29]

Some notes below. There's a bit too much dupe logic and I'd prefer if we could
work towards either an all template/handlebars or an all JS object method of
generating the content. Beyond that, there's design updates from last week that
will change much of the content in the tests/rendering.

https://codereview.appspot.com/8488045/diff/1/app/templates/charm-container.h...
File app/templates/charm-container.handlebars (right):

https://codereview.appspot.com/8488045/diff/1/app/templates/charm-container.h...
app/templates/charm-container.handlebars:5: See {{ this.extra }} more
{{pluralize 'result' this.extra}}
this has been changed to just the number + an icon for showing toggle state in
teh latest designs. Check the assets/jpg screen designs/search_full_filters.jpg
for a sample.

https://codereview.appspot.com/8488045/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/8488045/diff/1/app/views/utils.js#newcode1169
app/views/utils.js:1169: Y.Handlebars.registerHelper('pluralize',
can you add a doc block to this with comments on example and known limitations
(only does a s or manual alternate)?

https://codereview.appspot.com/8488045/diff/1/app/widgets/charm-container.js
File app/widgets/charm-container.js (right):

https://codereview.appspot.com/8488045/diff/1/app/widgets/charm-container.js#...
app/widgets/charm-container.js:37: SEE_MORE: 'See {extra} more {result}',
we have this content now in the template and in the JS object here. Would it be
better to render in the template both enabled/disabled versions and toggle which
is displayed vs changing the actual content and duplicating the strings?

https://codereview.appspot.com/8488045/diff/1/app/widgets/charm-container.js#...
app/widgets/charm-container.js:91: var extra = this.get('extra'),
see previous comment as again this is duplicate logic that's in the handlebars
helpers doing this plural/etc for us. The other thing is to move this back into
JS from the template and dump to the template as
Y.Object.merge({'recent_activity', this._generateRecentActivity},
this.getAttrs());

[j.c.sackett, 2013-04-08 19:40:01]

Please take a look.

[j.c.sackett, 2013-04-08 20:24:29]

I didn't address the needs to make design changes in this branch; I have a
follow up that does so.

I cannot for the life of me figure out how to make Rietveld understand
pipes/prereq branches, so I haven't submitted it yet.

[rharding, 2013-04-08 20:35:19]

LGTM thanks for the updates. Hopefully with the design changes coming it'll get
even simpler.

[jeff.pihach, 2013-04-08 21:49:30]

LGTM That will be a nice helper to have going forward I'm sure. couple notes
down below.

https://codereview.appspot.com/8488045/diff/6001/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/8488045/diff/6001/app/views/utils.js#newcode1180
app/views/utils.js:1180: * cases are handled by passing in a plural form (e.g.
octopus => ocotopi).
Good thinking, plurals are very hard to do automatically.

https://codereview.appspot.com/8488045/diff/6001/app/widgets/charm-container.js
File app/widgets/charm-container.js (right):

https://codereview.appspot.com/8488045/diff/6001/app/widgets/charm-container....
app/widgets/charm-container.js:86: expander.one('.more').addClass('hidden');
a little more efficient way to do this would be to cache these nodes at the top
of the fn and then act on the results here.

https://codereview.appspot.com/8488045/diff/6001/test/test_charm_container.js
File test/test_charm_container.js (right):

https://codereview.appspot.com/8488045/diff/6001/test/test_charm_container.js...
test/test_charm_container.js:88: it('toggles between all or a just few items
being shown', function() {
possible typo here? "or a just few"

[j.c.sackett, 2013-04-09 13:24:06]

*** Submitted:

Adds template helpers e.g. for pluralization.

-Adds a pluralize template helper for pluralizing words based on
length or size of an object or number passed in.
-Adds a helper to handle the "no extra items" case for charm container, rather
than an otherwise awkward attribute.
-Adds tests
-Updates code and templates.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/8488045