Issue 84350043: Have the apiserver know the logdir

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84350043: Have the apiserver know the logdir

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by thumper

Modified:
10 years ago

Reviewers:
mp+214155, axw

Visibility:
Public.

Description

Have the apiserver know the logdir The agent config now knows the logdir. In some places the entire agent config is passed through, but in order to keep the changes small(ish), we only pass through the logdir (additionally). This did require a few tweaks to tests, and in particular the addition of LogDir to the base ConnSuite. This logdir is used by the upcoming debug-log api. https://code.launchpad.net/~thumper/juju-core/apiserver-knows-logdir/+merge/214155 Requires: https://code.launchpad.net/~thumper/juju-core/tailer-tweaks/+merge/214150 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -5 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	juju/testing/conn.go	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	provider/dummy/environs.go	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	state/apiserver/apiserver.go	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	state/apiserver/login_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/server_test.go	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2014/04/04 04:47:42, thumper wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages