code review 84300043: cmd/go: always build package during "go test" command

cmd/go: always build package during "go test" command

even when there are no *_test.go files present.
rsc suggested this change

Fixes issue 7108

[brainman, 2014-04-04 01:19:15]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2014-04-04 01:20:07]

This will, probably, break some builds. :-)

Alex

[r, 2014-04-09 06:32:59]

Is there a reason to do this for 1.3? I'd rather break builds later, thank you.

[brainman, 2014-04-09 06:42:23]

On 2014/04/09 06:32:59, r wrote:
> Is there a reason to do this for 1.3? I'd rather break builds later, thank
you.

I don't think we need this for 1.3. But rsc has asked for it here
https://code.google.com/p/go/issues/detail?id=7108#c6. I am happy to leave it
for later. Your call.

Alex

[r, 2014-04-09 06:57:27]

Well, he also asked for a test in test.bash, which you didn't provide. If you
provide it, I am inclined to approve this CL for 1.3.

[brainman, 2014-04-10 02:55:35]

Hello golang-codereviews@googlegroups.com, r@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[brainman, 2014-04-10 02:56:20]

On 2014/04/09 06:57:27, r wrote:
> ... he also asked for a test in test.bash, which you didn't provide. ...

I missed that. PTAL with test.bash change now.

Also note that this change will break go.blog and go.talks repos. I don't know
how to fix them.

Alex

[r, 2014-04-10 02:58:28]

LGTM but wait for adg to sign off because of the pending breakages.

[adg, 2014-04-10 03:22:05]

LGTM

[brainman, 2014-04-10 04:02:31]

*** Submitted as https://code.google.com/p/go/source/detail?r=a79e99b1b44c ***

cmd/go: always build package during "go test" command

even when there are no *_test.go files present.
rsc suggested this change

Fixes issue 7108

LGTM=r, adg
R=golang-codereviews, r, adg
CC=golang-codereviews
https://codereview.appspot.com/84300043

[oleku, 2014-04-10 20:18:38]

What would happen when "go test app_test.go" is called ? 

- Does it try to build all files in the folder
- Does it try to build app.go 
- Does it just ignore the build phase since a file was specified ? 



On 2014/04/10 04:02:31, brainman wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=a79e99b1b44c ***
> 
> cmd/go: always build package during "go test" command
> 
> even when there are no *_test.go files present.
> rsc suggested this change
> 
> Fixes issue 7108
> 
> LGTM=r, adg
> R=golang-codereviews, r, adg
> CC=golang-codereviews
> https://codereview.appspot.com/84300043

[brainman, 2014-04-11 03:50:48]

On 2014/04/10 20:18:38, oleku wrote:
> What would happen when "go test app_test.go" is called ? 
> 
> - Does it try to build all files in the folder
> - Does it try to build app.go 
> - Does it just ignore the build phase since a file was specified ? 
> 

You can try it yourself, if you're interested.

Alex

[dave_cheney.net, 2014-04-12 05:22:15]

I think this had the unexpected side effect of breaking all the sample code in
the go.blog sub repo.

[brainman, 2014-04-12 05:25:39]

On 2014/04/12 05:22:15, dfc wrote:
> I think this had the unexpected side effect of breaking all the sample code in
> the go.blog sub repo.

That is what I said in #7. I guess r and adg have some plan to fix that.

Alex

[dave_cheney.net, 2014-04-12 05:26:23]

Jolly good, carry on.

On Sat, Apr 12, 2014 at 3:25 PM,  <alex.brainman@gmail.com> wrote:
> On 2014/04/12 05:22:15, dfc wrote:
>>
>> I think this had the unexpected side effect of breaking all the sample
>
> code in
>>
>> the go.blog sub repo.
>
>
> That is what I said in #7. I guess r and adg have some plan to fix that.
>
> Alex
>
> https://codereview.appspot.com/84300043/