Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1364)

Issue 83940043: state: no pre-checks for injected machines

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by axw
Modified:
9 years, 12 months ago
Reviewers:
mp+213989, fwereade
Visibility:
Public.

Description

state: no pre-checks for injected machines We should not be second guessing the bootstrap agent or manual provisioning. If the instance-id is non-empty when adding a machine to state, do not check SupportsUnitPlacement. https://code.launchpad.net/~axwalk/juju-core/fix-supportsunitplacement-injectmachine/+merge/213989 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : state: no pre-checks for injected machines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M state/addmachine.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M state/environcapability_test.go View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 3
axw
Please take a look.
9 years, 12 months ago (2014-04-03 09:59:53 UTC) #1
fwereade
LGTM https://codereview.appspot.com/83940043/diff/1/state/addmachine.go File state/addmachine.go (left): https://codereview.appspot.com/83940043/diff/1/state/addmachine.go#oldcode137 state/addmachine.go:137: // only permitted unit placement is supported. s/permitted/permitted ...
9 years, 12 months ago (2014-04-03 10:06:56 UTC) #2
axw
9 years, 12 months ago (2014-04-03 10:15:49 UTC) #3
Please take a look.

https://codereview.appspot.com/83940043/diff/1/state/addmachine.go
File state/addmachine.go (left):

https://codereview.appspot.com/83940043/diff/1/state/addmachine.go#oldcode137
state/addmachine.go:137: // only permitted unit placement is supported.
On 2014/04/03 10:06:57, fwereade wrote:
> s/permitted/permitted if/

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b