Issue 8357044: code review 8357044: go.ext/locale: added a function for the common pattern ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8357044: code review 8357044: go.ext/locale: added a function for the common pattern ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by mpvl

Modified:
11 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go.ext/locale: added a function for the common pattern [n<<2:][:4] and changed some of the functions to take the index as an argument so that testing functions do not need to modify global variables.

Patch Set 1 #

Patch Set 2 : diff -r faab6deef005 https://code.google.com/p/go.exp/ #

Patch Set 3 : diff -r faab6deef005 https://code.google.com/p/go.exp/ #

Patch Set 4 : diff -r faab6deef005 https://code.google.com/p/go.exp/ #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -18 lines)			Patch
	M	locale/lookup.go	View	1 2 3	4 chunks	+18 lines, -12 lines	0 comments	Download
	M	locale/lookup_test.go	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mpvl

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.exp/

11 years ago (2013-04-04 14:30:00 UTC) #1

mpvl

11 years ago (2013-04-09 13:08:11 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=091c2b6f39b9&repo=exp ***

go.ext/locale: added a function for the common pattern [n<<2:][:4] and
changed some of the functions to take the index as an argument so that
testing functions do not need to modify global variables.

R=r
CC=golang-dev
https://codereview.appspot.com/8357044

Expand All Messages | Collapse All Messages