Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(761)

Issue 83530043: environs/cloudinit: use StateServingInfo

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by rog
Modified:
6 years, 6 months ago
Reviewers:
mp+213791, fwereade
Visibility:
Public.

Description

environs/cloudinit: use StateServingInfo We use StateServingInfo in MachineConfig, because it exactly represents what we want to store there. We also change the arguments to agent.NewStateMachineConfig to separate out the StateServingInfo, allowing us to drop the extra params struct type. We also rename MachineConfig.StateServer to MachineConfig.Bootstrap, because extra state server machines should not have StateServingInfo in them - Bootstrap more accurately reflects its meaning. https://code.launchpad.net/~rogpeppe/juju-core/536-machineconfig-stateservinginfo/+merge/213791 Requires: https://code.launchpad.net/~mfoord/juju-core/stateservinginfo/+merge/212874 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/cloudinit: use StateServingInfo #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -290 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M agent/agent.go View 1 1 chunk +8 lines, -21 lines 0 comments Download
M agent/agent_test.go View 1 5 chunks +41 lines, -37 lines 0 comments Download
M agent/bootstrap_test.go View 1 2 chunks +31 lines, -30 lines 0 comments Download
M agent/format_whitebox_test.go View 1 chunk +9 lines, -9 lines 0 comments Download
M cmd/jujud/agent_test.go View 1 chunk +15 lines, -15 lines 0 comments Download
M cmd/jujud/bootstrap_test.go View 1 chunk +21 lines, -21 lines 1 comment Download
M environs/cloudinit.go View 3 chunks +16 lines, -11 lines 1 comment Download
M environs/cloudinit/cloudinit.go View 11 chunks +31 lines, -40 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 18 chunks +99 lines, -85 lines 0 comments Download
M environs/cloudinit_test.go View 6 chunks +25 lines, -21 lines 0 comments Download

Messages

Total messages: 2
rog
Please take a look.
6 years, 6 months ago (2014-04-02 09:48:42 UTC) #1
fwereade
6 years, 6 months ago (2014-04-02 10:52:38 UTC) #2
LGTM, this makes me happy.

https://codereview.appspot.com/83530043/diff/20001/cmd/jujud/bootstrap_test.go
File cmd/jujud/bootstrap_test.go (left):

https://codereview.appspot.com/83530043/diff/20001/cmd/jujud/bootstrap_test.g...
cmd/jujud/bootstrap_test.go:114: // really should be using
NewStateMachineConfig.
d?

https://codereview.appspot.com/83530043/diff/20001/environs/cloudinit.go
File environs/cloudinit.go (right):

https://codereview.appspot.com/83530043/diff/20001/environs/cloudinit.go#newc...
environs/cloudinit.go:64: mcfg.Bootstrap = true
yay!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b