Issue 83530043: environs/cloudinit: use StateServingInfo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 83530043: environs/cloudinit: use StateServingInfo

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by rog

Modified:
10 years ago

Reviewers:
mp+213791, fwereade

Visibility:
Public.

Description

environs/cloudinit: use StateServingInfo We use StateServingInfo in MachineConfig, because it exactly represents what we want to store there. We also change the arguments to agent.NewStateMachineConfig to separate out the StateServingInfo, allowing us to drop the extra params struct type. We also rename MachineConfig.StateServer to MachineConfig.Bootstrap, because extra state server machines should not have StateServingInfo in them - Bootstrap more accurately reflects its meaning. https://code.launchpad.net/~rogpeppe/juju-core/536-machineconfig-stateservinginfo/+merge/213791 Requires: https://code.launchpad.net/~mfoord/juju-core/stateservinginfo/+merge/212874 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/cloudinit: use StateServingInfo #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+298 lines, -290 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	agent/agent.go	View	1	1 chunk	+8 lines, -21 lines	0 comments	Download
M	agent/agent_test.go	View	1	5 chunks	+41 lines, -37 lines	0 comments	Download
M	agent/bootstrap_test.go	View	1	2 chunks	+31 lines, -30 lines	0 comments	Download
M	agent/format_whitebox_test.go	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	cmd/jujud/agent_test.go	View		1 chunk	+15 lines, -15 lines	0 comments	Download
M	cmd/jujud/bootstrap_test.go	View		1 chunk	+21 lines, -21 lines	1 comment	Download
M	environs/cloudinit.go	View		3 chunks	+16 lines, -11 lines	1 comment	Download
M	environs/cloudinit/cloudinit.go	View		11 chunks	+31 lines, -40 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View		18 chunks	+99 lines, -85 lines	0 comments	Download
M	environs/cloudinit_test.go	View		6 chunks	+25 lines, -21 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

10 years ago (2014-04-02 10:52:38 UTC) #2

LGTM, this makes me happy.

https://codereview.appspot.com/83530043/diff/20001/cmd/jujud/bootstrap_test.go
File cmd/jujud/bootstrap_test.go (left):

https://codereview.appspot.com/83530043/diff/20001/cmd/jujud/bootstrap_test.g...
cmd/jujud/bootstrap_test.go:114: // really should be using
NewStateMachineConfig.
d?

https://codereview.appspot.com/83530043/diff/20001/environs/cloudinit.go
File environs/cloudinit.go (right):

https://codereview.appspot.com/83530043/diff/20001/environs/cloudinit.go#newc...
environs/cloudinit.go:64: mcfg.Bootstrap = true
yay!

Expand All Messages | Collapse All Messages