Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 83300047: worker/singular: new package

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by rog
Modified:
5 years, 10 months ago
Reviewers:
wwitzel3, mp+213874
Visibility:
Public.

Description

worker/singular: new package This acts as a wrapper that will allow us to start workers that require only one instance. https://code.launchpad.net/~rogpeppe/juju-core/535-worker-singular/+merge/213874 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : worker/singular: new package #

Total comments: 2

Patch Set 3 : worker/singular: new package #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -0 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A worker/singular/singular.go View 1 2 1 chunk +115 lines, -0 lines 0 comments Download
A worker/singular/singular_test.go View 1 chunk +218 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
5 years, 10 months ago (2014-04-02 15:23:44 UTC) #1
wwitzel3
LGTM https://codereview.appspot.com/83300047/diff/20001/worker/singular/singular.go File worker/singular/singular.go (right): https://codereview.appspot.com/83300047/diff/20001/worker/singular/singular.go#newcode61 worker/singular/singular.go:61: Even though it is internal it might be ...
5 years, 10 months ago (2014-04-02 16:02:52 UTC) #2
rog
5 years, 10 months ago (2014-04-02 16:06:59 UTC) #3
Please take a look.

https://codereview.appspot.com/83300047/diff/20001/worker/singular/singular.go
File worker/singular/singular.go (right):

https://codereview.appspot.com/83300047/diff/20001/worker/singular/singular.g...
worker/singular/singular.go:61: 
On 2014/04/02 16:02:52, wwitzel3 wrote:
> Even though it is internal it might be nice to at least have a small comment
> that points to the great implications of the use of pinger else where since to
> me it is isn't obviously clear its purpose .. though that just might be me
being
> naive about golang.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b