Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1255)

Issue 83270048: Bundle proof errors if juju-gui included.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by bac
Modified:
9 years, 12 months ago
Reviewers:
mp+213923, jeff.pihach
Visibility:
Public.

Description

Bundle proof errors if juju-gui included. The juju-gui should not be a part of a bundle, though the juju-gui export mechanism has historically included it when doing the export. Because it has been in the exports, and most bundles start out as an export that then gets tuned, a lot of existing bundles have juju-gui in them. https://code.launchpad.net/~bac/charmworld/proof-bundles-with-juju-gui/+merge/213923 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bundle proof errors if juju-gui included. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/views/api/proof.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M charmworld/views/tests/test_proof.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7
bac
Please take a look.
9 years, 12 months ago (2014-04-02 20:27:07 UTC) #1
jeff.pihach
Thanks for this enhancement! Please see comment. https://codereview.appspot.com/83270048/diff/1/charmworld/views/api/proof.py File charmworld/views/api/proof.py (right): https://codereview.appspot.com/83270048/diff/1/charmworld/views/api/proof.py#newcode317 charmworld/views/api/proof.py:317: if name.lower() ...
9 years, 12 months ago (2014-04-02 20:36:01 UTC) #2
bac
To QA: 1) Create a bundle that has juju-gui as a service name. 2) In ...
9 years, 12 months ago (2014-04-02 20:36:24 UTC) #3
jeff.pihach
As per the discussion on IRC LGTM because the service name is what causes issues, ...
9 years, 12 months ago (2014-04-02 20:48:03 UTC) #4
bac
Thanks for the review Jeff.
9 years, 12 months ago (2014-04-02 20:55:18 UTC) #5
bac
. https://codereview.appspot.com/83270048/diff/1/charmworld/views/api/proof.py File charmworld/views/api/proof.py (right): https://codereview.appspot.com/83270048/diff/1/charmworld/views/api/proof.py#newcode317 charmworld/views/api/proof.py:317: if name.lower() == 'juju-gui': As we agreed on ...
9 years, 12 months ago (2014-04-02 20:55:30 UTC) #6
bac
9 years, 12 months ago (2014-04-03 13:47:55 UTC) #7
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b