Issue 83250044: cloudinit: always install curl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 83250044: cloudinit: always install curl

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by jameinel

Modified:
10 years ago

Reviewers:
mp+213837, gz, dfc

Visibility:
Public.

Description

cloudinit: always install curl Our cloud images always come with curl installed, but manual instances may not (bug #1300321). It doesn't hurt to install a package that is already there, so this is a trivial patch to just depend on having curl installed. https://code.launchpad.net/~jameinel/juju-core/1.18-always-ensure-curl-1300321/+merge/213837 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/cloudinit/cloudinit.go	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM. Ugh. Dimiter had this in the initial version, but I got him to remove ...

10 years ago (2014-04-02 13:13:32 UTC) #2

dfc

10 years ago (2014-04-02 20:44:42 UTC) #3

On 2014/04/02 13:13:32, gz wrote:
> LGTM. Ugh. Dimiter had this in the initial version, but I got him to remove it
> as it's redundant for anyone actually using our stuff. And of course, someone
> breaks from not using our cloud-images.

LGTM. I agree with your diagnosis

Expand All Messages | Collapse All Messages