Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3383)

Issue 8311043: Start to style the Gui Browser fullscreen.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rharding
Modified:
11 years ago
Reviewers:
mp+156820, jeff.pihach
Visibility:
Public.

Description

Start to style the Gui Browser fullscreen. - Add assets and css into the sprite list. - Update the html of a few sections to match design docs https://code.launchpad.net/~rharding/juju-gui/fullscreen_ux/+merge/156820 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Start to style the Gui Browser fullscreen. #

Patch Set 3 : Start to style the Gui Browser fullscreen. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1538 lines, -42 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/images/browser_add_button_left.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_add_button_right.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_back_button_centre.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_back_button_left.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_back_button_right.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_icon.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_minimize.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_searchbox_left.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/browser_searchbox_right.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/charm_commits_icon.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/charm_downloads_icon.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/header_nav_border.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/provider_icons/provider-aws.svg View 1 chunk +148 lines, -0 lines 0 comments Download
A app/assets/images/provider_icons/provider-cloud.svg View 1 chunk +99 lines, -0 lines 0 comments Download
A app/assets/images/provider_icons/provider-hp.svg View 1 chunk +224 lines, -0 lines 0 comments Download
A app/assets/images/provider_icons/provider-lxc01.svg View 1 chunk +99 lines, -0 lines 0 comments Download
A app/assets/images/provider_icons/provider-lxc02.svg View 1 chunk +103 lines, -0 lines 0 comments Download
A app/assets/images/provider_icons/provider-maas.svg View 1 chunk +90 lines, -0 lines 0 comments Download
A app/assets/images/provider_icons/provider-openstack.svg View 1 chunk +498 lines, -0 lines 0 comments Download
A app/assets/images/share_icon.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/tab_active_centre.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/tab_active_left.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/tab_active_right.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/tab_inactive_centre.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/tab_inactive_left.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/tab_inactive_right.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 2 2 chunks +54 lines, -36 lines 0 comments Download
M app/subapps/browser/templates/fullscreen.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/subapps/browser/templates/sidebar.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/subapps/browser/views/charm.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M app/subapps/browser/views/fullscreen.js View 1 chunk +1 line, -1 line 0 comments Download
M app/subapps/browser/views/sidebar.js View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/browser-search.handlebars View 1 chunk +11 lines, -6 lines 0 comments Download
M app/widgets/charm-search.js View 1 chunk +1 line, -0 lines 0 comments Download
A lib/views/browser/charm-full.less View 1 chunk +117 lines, -0 lines 0 comments Download
M lib/views/browser/main.less View 1 chunk +67 lines, -9 lines 0 comments Download
M lib/views/browser/tabview.less View 1 chunk +32 lines, -0 lines 0 comments Download
M lib/views/stylesheet.less View 1 chunk +2 lines, -0 lines 0 comments Download
M test/test_browser_charm_details.js View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
11 years ago (2013-04-03 12:01:01 UTC) #1
rharding
LGTM thanks for the update. Almost starts to look like the pretty pictures :)
11 years ago (2013-04-03 12:08:28 UTC) #2
jeff.pihach
LGTM - small issue in the Add button in OSX Chrome, I'll create another ticket ...
11 years ago (2013-04-03 15:42:45 UTC) #3
rharding
11 years ago (2013-04-03 16:19:00 UTC) #4
*** Submitted:

Start to style the Gui Browser fullscreen.

- Add assets and css into the sprite list.
- Update the html of a few sections to match design docs

R=jeff.pihach
CC=
https://codereview.appspot.com/8311043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b