Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1200)

Issue 83090044: state/api: listen on localhost explicitly

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by rog
Modified:
9 years, 12 months ago
Reviewers:
wwitzel3, mp+213675, mfoord
Visibility:
Public.

Description

state/api: listen on localhost explicitly If we listen on ":0", the address returned from Addr is all-zeros, which is not always valid for dialling localhost. (I'm not sure why it ever is, actually) So we listen on 127.0.0.1 explicitly. https://code.launchpad.net/~rogpeppe/juju-core/537-listen-localhost/+merge/213675 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M provider/local/local_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/apiclient_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/api/client_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
9 years, 12 months ago (2014-04-01 15:32:26 UTC) #1
mfoord
On 2014/04/01 15:32:26, rog wrote: > Please take a look. LGTM
9 years, 12 months ago (2014-04-01 15:34:34 UTC) #2
wwitzel3
9 years, 12 months ago (2014-04-01 15:34:56 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b