Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 8303043: code review 8303043: crypto/rand: better panic message for invalid Int argument. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by remyoudompheng
Modified:
9 years, 7 months ago
Reviewers:
CC:
golang-dev, dfc, bradfitz, r
Visibility:
Public.

Description

crypto/rand: better panic message for invalid Int argument. Also document the panic to be consistent with math/rand. Fixes issue 5187.

Patch Set 1 #

Patch Set 2 : diff -r cfe93dfc5788 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cfe93dfc5788 https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/pkg/crypto/rand/util.go View 1 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 7
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 8 months ago (2013-04-03 06:15:41 UTC) #1
dfc
Thank you. Leaving for the release candidate masters to decide if it makes the cut. ...
9 years, 8 months ago (2013-04-03 06:18:21 UTC) #2
bradfitz
LGTM Don't care about nil too? On Tue, Apr 2, 2013 at 11:15 PM, <remyoudompheng@gmail.com> ...
9 years, 8 months ago (2013-04-03 07:50:14 UTC) #3
remyoudompheng
Is this okay for Go 1.1? What about: - the rand package? - the nil ...
9 years, 8 months ago (2013-04-08 07:05:54 UTC) #4
bradfitz
Seems fine for 1.1, but I'm not concerned either way. If it's going to crash ...
9 years, 8 months ago (2013-04-08 07:09:06 UTC) #5
r
LGTM
9 years, 7 months ago (2013-04-15 19:53:47 UTC) #6
bradfitz
9 years, 7 months ago (2013-04-18 06:21:19 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=4543c39256f9 ***

crypto/rand: better panic message for invalid Int argument.

Also document the panic to be consistent with math/rand.

Fixes issue 5187.

R=golang-dev, dave, bradfitz, r
CC=golang-dev
https://codereview.appspot.com/8303043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b