Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(345)

Issue 82970043: instance.NewAddress now requires an explicit scope

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by dfc
Modified:
9 years, 12 months ago
Reviewers:
mp+213575, fwereade
Visibility:
Public.

Description

instance.NewAddress now requires an explicit scope Update LP 1298770 Update instance.NewAddress and all callers to pass an explicit scope. This fixed cases where the Address was bodged after creation. More importantly it has now exposed the dozens of places where an Address is created with scope NetworkUnknown. I hope this makes you as uneasy as I. https://code.launchpad.net/~dave-cheney/juju-core/106-add-scope-to-instance-new-address/+merge/213575 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : instance.NewAddress now requires an explicit scope #

Patch Set 3 : instance.NewAddress now requires an explicit scope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -126 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/ssh_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M cmd/juju/status_test.go View 25 chunks +36 lines, -36 lines 0 comments Download
M cmd/jujud/machine_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/manual/addresses_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M instance/address.go View 3 chunks +8 lines, -5 lines 0 comments Download
M instance/address_test.go View 5 chunks +19 lines, -13 lines 0 comments Download
M juju/apiconn_test.go View 1 chunk +1 line, -1 line 0 comments Download
M juju/testing/utils.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/common/bootstrap_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M provider/joyent/instance.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/maas/instance_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M state/api/deployer/deployer_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/api/machiner/machiner_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M state/api/provisioner/provisioner_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/api/testing/apiaddresser.go View 2 chunks +3 lines, -3 lines 0 comments Download
M state/apiserver/client/client_test.go View 5 chunks +7 lines, -13 lines 0 comments Download
M state/apiserver/client/run_test.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M state/apiserver/deployer/deployer_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/apiserver/login_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/machine/machiner_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M state/apiserver/uniter/uniter_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/machine_test.go View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M state/megawatcher_internal_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/state_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M state/statecmd/machineconfig_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/unit_test.go View 1 2 2 chunks +4 lines, -8 lines 0 comments Download
M worker/instancepoller/machine_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M worker/instancepoller/worker_test.go View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M worker/machiner/machiner.go View 1 chunk +6 lines, -1 line 0 comments Download
M worker/machiner/machiner_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/provisioner/kvm-broker_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/lxc-broker_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/provisioner_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dfc
Please take a look.
10 years ago (2014-04-01 03:49:07 UTC) #1
fwereade
LGTM, thanks. FWIW, I'm not so sure it's quite as bad as you think, but ...
10 years ago (2014-04-01 08:20:28 UTC) #2
dfc
9 years, 12 months ago (2014-04-01 23:58:05 UTC) #3
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b