Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10236)

Issue 8296043: Add support for displaying interfaces data.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rharding
Modified:
11 years ago
Reviewers:
mp+156723, j.c.sackett, jeff.pihach
Visibility:
Public.

Description

Add support for displaying interfaces data. - Add a handlebars helper to output objects as arrays - update the previous branch in the configuration tab to use it - Add output from the relations property of the charmworld0 api to the model - Add the rendered output to the charm view template. https://code.launchpad.net/~rharding/juju-gui/interfaces_tab/+merge/156723 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add support for displaying interfaces data. #

Patch Set 3 : Add support for displaying interfaces data. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -89 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 1 2 4 chunks +83 lines, -27 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 chunk +55 lines, -7 lines 0 comments Download
M app/subapps/browser/views/charm.js View 2 chunks +2 lines, -4 lines 0 comments Download
M app/views/utils.js View 1 chunk +14 lines, -0 lines 0 comments Download
M test/test_model.js View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
11 years ago (2013-04-03 00:36:40 UTC) #1
j.c.sackett
LGTM, thanks!
11 years ago (2013-04-03 14:19:42 UTC) #2
jeff.pihach
LGTM nice little improvement. I have a couple suggestions below :-) https://codereview.appspot.com/8296043/diff/1/app/models/charm.js File app/models/charm.js (right): ...
11 years ago (2013-04-03 14:48:36 UTC) #3
rharding
11 years ago (2013-04-03 15:26:28 UTC) #4
*** Submitted:

Add support for displaying interfaces data.

- Add a handlebars helper to output objects as arrays
- update the previous branch in the configuration tab to use it
- Add output from the relations property of the charmworld0 api to the model 
- Add the rendered output to the charm view template.

R=j.c.sackett, jeff.pihach
CC=
https://codereview.appspot.com/8296043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b