Issue 8294044: state: use allInfo.update only

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8294044: state: use allInfo.update only

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rog

Modified:
11 years ago

Reviewers:
dimitern, mp+157389, fwereade, gz

Visibility:
Public.

Description

state: use allInfo.update only We consider allInfo.markRemoved and add alInfo.add to be private methods. I'm considering adding a leading underscore to methods that should be considered private. Thoughts appreciated in that respect. https://code.launchpad.net/~rogpeppe/juju-core/269-megawatcher-use-update-not-markremoved/+merge/157389 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: use allInfo.update only #

Patch Set 3 : state: use allInfo.update only #

Patch Set 4 : state: use allInfo.update only #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -18 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/megabacking.go	View	1 2	2 chunks	+2 lines, -6 lines	0 comments	Download
M	state/megawatcher.go	View	1 2	5 chunks	+10 lines, -1 line	0 comments	Download
M	state/megawatcher_internal_test.go	View		10 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

LGTM. The idea of using underscores rather than just comments above the file-internal functions seems ...

11 years ago (2013-04-05 15:50:54 UTC) #4

fwereade

11 years ago (2013-04-05 21:09:57 UTC) #5

On 2013/04/05 15:50:54, gz wrote:
> LGTM.
> 
> The idea of using underscores rather than just comments above the
file-internal
> functions seems reasonable to me.

+1; LGTM with that (the comments are IMO not obvious enough)

Expand All Messages | Collapse All Messages