Make the test not use a fixed port.

Make the test not use a fixed port.

Simple change to avoid a fixed port in the test.

https://code.launchpad.net/~thumper/juju-core/client-test-no-fixed-port/+merge/213582

(do not edit description out of merge proposal)

[thumper, 2014-04-01 04:40:56]

Please take a look.

[axw, 2014-04-01 04:47:19]

LGTM

https://codereview.appspot.com/82940044/diff/1/state/api/client_test.go
File state/api/client_test.go (right):

https://codereview.appspot.com/82940044/diff/1/state/api/client_test.go#newco...
state/api/client_test.go:72: url := fmt.Sprintf("http://localhost:%d", port)
This can be simplified to:
    fmt.Sprintf("http://%s", lis.Addr())

[axw, 2014-04-01 04:48:36]

https://codereview.appspot.com/82940044/diff/1/state/api/client_test.go
File state/api/client_test.go (right):

https://codereview.appspot.com/82940044/diff/1/state/api/client_test.go#newco...
state/api/client_test.go:69: lis, err := net.Listen("tcp", ":0")
Sorry, just realised: please defer lis.Close() after checking the error.

[thumper, 2014-04-01 05:45:36]

Please take a look.

https://codereview.appspot.com/82940044/diff/1/state/api/client_test.go
File state/api/client_test.go (left):

https://codereview.appspot.com/82940044/diff/1/state/api/client_test.go#oldco...
state/api/client_test.go:75: c.Assert(err, gc.IsNil)
Had to remove the assert as it now returned a "use of closed connection" error,
and we don't actually care about the error.

https://codereview.appspot.com/82940044/diff/1/state/api/client_test.go
File state/api/client_test.go (right):

https://codereview.appspot.com/82940044/diff/1/state/api/client_test.go#newco...
state/api/client_test.go:69: lis, err := net.Listen("tcp", ":0")
On 2014/04/01 04:48:36, axw wrote:
> Sorry, just realised: please defer lis.Close() after checking the error.

ok

https://codereview.appspot.com/82940044/diff/1/state/api/client_test.go#newco...
state/api/client_test.go:72: url := fmt.Sprintf("http://localhost:%d", port)
On 2014/04/01 04:47:19, axw wrote:
> This can be simplified to:
>     fmt.Sprintf("http://%s", lis.Addr())

Done.