Issue 82910044: Update LP 1301706

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 82910044: Update LP 1301706

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by dfc

Modified:
10 years ago

Reviewers:
mp+213971, fwereade

Visibility:
Public.

Description

Update LP 1301706 Whie investigating LP 1301706 I noticed that there were a few interface conversions which did not panic if the data coming back from mongo was corrupted. I think that this is wrong and the three conversions I've changed should panic if their do not match the expected type. I hope this will also give some clarity to the underlying issue which is panicing as if a nil was passed to the filter func. https://code.launchpad.net/~dave-cheney/juju-core/122-fix-lp-1301706/+merge/213971 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	state/watcher/watcher.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

10 years ago (2014-04-03 08:39:16 UTC) #2

I'm ambivalent about this. It's nice to stop when we encounter corrupted data,
but it's not so nice add new ways to panic the API server. Guy says not lgtm on
those grounds -- i think I'd rather log a suitably terrifying error and keep
going despite the degraded functionality.

Counterargument?

Expand All Messages | Collapse All Messages