Issue 8277048: issue #353 : FootNote doesn't work with non-ASCII

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8277048: issue #353 : FootNote doesn't work with non-ASCII (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by sunu0000

Modified:
9 years, 1 month ago

Reviewers:
waldi

Visibility:
Public.

More Reviews

Description

issue #353 : FootNote doesn't work with non-ASCII

Patch Set 1 #

Total comments: 3

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	MoinMoin/converter/_args_wiki.py	View		5 chunks	+5 lines, -5 lines	3 comments	Download
	M	MoinMoin/converter/_tests/test__args_wiki.py	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

waldi

11 years ago (2013-04-08 15:41:20 UTC) #1

Please properly describe what you are trying to do. Except for the two
re.UNICODE changes, I see nothing that is suitable.

https://codereview.appspot.com/8277048/diff/1/MoinMoin/converter/_args_wiki.py
File MoinMoin/converter/_args_wiki.py (right):

https://codereview.appspot.com/8277048/diff/1/MoinMoin/converter/_args_wiki.p...
MoinMoin/converter/_args_wiki.py:33: _parse_re = re.compile(_parse_rules, re.X |
re.UNICODE)
Maybe okay

https://codereview.appspot.com/8277048/diff/1/MoinMoin/converter/_args_wiki.p...
MoinMoin/converter/_args_wiki.py:48: value = (match.group(2) or match.group(3)
or match.group(4))
Nope. The strings can be escaped. And they are documented this way.

https://codereview.appspot.com/8277048/diff/1/MoinMoin/converter/_args_wiki.p...
MoinMoin/converter/_args_wiki.py:75: value = u'"' + value + u'"'
Not okay

Expand All Messages | Collapse All Messages