Issue 8269043: state: add indirection to allWatcher

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8269043: state: add indirection to allWatcher

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rog

Modified:
11 years ago

Reviewers:
dimitern, mp+156647, TheMue

Visibility:
Public.

Description

state: add indirection to allWatcher We allow the allWatcher backing to make its own decisions as to how the allInfo gets modified in response to database changes. https://code.launchpad.net/~rogpeppe/juju-core/264-megawatcher-indirect/+merge/156647 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: add indirection to allWatcher #

Patch Set 3 : state: add indirection to allWatcher #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+190 lines, -146 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/megawatcher.go	View		4 chunks	+22 lines, -22 lines	0 comments	Download
M	state/megawatcher_internal_test.go	View	1 2	21 chunks	+166 lines, -124 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

LGTM, will this make it easier to track changes in related documents, like status for ...

11 years ago (2013-04-03 08:07:31 UTC) #3

rog

On 3 April 2013 09:07, <dimiter.naydenov@canonical.com> wrote: > LGTM, will this make it easier to ...

11 years ago (2013-04-03 08:17:35 UTC) #4

rog

11 years ago (2013-04-03 13:32:24 UTC) #5

*** Submitted:

state: add indirection to allWatcher

We allow the allWatcher backing to make
its own decisions as to how the allInfo gets
modified in response to database changes.

R=TheMue, dimitern
CC=
https://codereview.appspot.com/8269043

Expand All Messages | Collapse All Messages