Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(894)

Issue 8250043: code review 8250043: doc/go1.1.html: additional tweaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by dave
Modified:
11 years ago
Reviewers:
CC:
r, adg, minux1, golang-dev
Visibility:
Public.

Description

doc/go1.1.html: additional tweaks

Patch Set 1 #

Patch Set 2 : diff -r 7d736eaa75da https://code.google.com/p/go #

Patch Set 3 : diff -r 7d736eaa75da https://code.google.com/p/go #

Total comments: 7

Patch Set 4 : diff -r 7d736eaa75da https://code.google.com/p/go #

Patch Set 5 : diff -r 7d736eaa75da https://code.google.com/p/go #

Patch Set 6 : diff -r 08977bd0dda2 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M doc/go1.1.html View 1 2 3 4 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 9
dave_cheney.net
Hello r@golang.org, adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years ago (2013-04-02 06:11:06 UTC) #1
adg
LGTM
11 years ago (2013-04-02 11:37:18 UTC) #2
r
https://codereview.appspot.com/8250043/diff/5001/doc/go1.1.html File doc/go1.1.html (right): https://codereview.appspot.com/8250043/diff/5001/doc/go1.1.html#newcode360 doc/go1.1.html:360: <code>openbsd/386</code> and <code>openbsd/amd64</code> platforms. An ARMv6 newline after sentence. ...
11 years ago (2013-04-02 13:52:18 UTC) #3
minux1
https://codereview.appspot.com/8250043/diff/5001/doc/go1.1.html File doc/go1.1.html (right): https://codereview.appspot.com/8250043/diff/5001/doc/go1.1.html#newcode361 doc/go1.1.html:361: or better processor is required for <code>freebsd/arm</code> or On ...
11 years ago (2013-04-02 13:58:54 UTC) #4
r
I think an amd64 is better than an arm, but that's not what you're trying ...
11 years ago (2013-04-02 15:21:56 UTC) #5
dave_cheney.net
Thank you for your comments. I'm sorry such a simple documentation exercise has consumed so ...
11 years ago (2013-04-03 01:48:54 UTC) #6
dave_cheney.net
Hello r@golang.org, adg@golang.org, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years ago (2013-04-03 01:49:20 UTC) #7
r
LGTM
11 years ago (2013-04-03 04:44:38 UTC) #8
dave_cheney.net
11 years ago (2013-04-03 05:55:03 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=cfe93dfc5788 ***

doc/go1.1.html: additional tweaks

R=r, adg, minux.ma
CC=golang-dev
https://codereview.appspot.com/8250043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b