Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5164)

Issue 82480043: Improve ssh.ReplaceKeys (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by wallyworld
Modified:
10 years ago
Reviewers:
wwitzel3, mp+213406, jameinel
Visibility:
Public.

Description

Improve ssh.ReplaceKeys ReplaceKeys is used by the authentication worker to write ssh keys to ~/.ssh/authorized_keys. It merges existing keys with those added to Juju. It checks that all keys to be written have comments, but existing keys may not have comments. The check for key comment is done as any keys are added to Juju so the check in ReplaceKeys can be removed. https://code.launchpad.net/~wallyworld/juju-core/replace-ssh-keys-fix/+merge/213406 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M utils/ssh/authorisedkeys.go View 1 chunk +0 lines, -9 lines 0 comments Download
M utils/ssh/authorisedkeys_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
wallyworld
Please take a look.
10 years ago (2014-03-31 05:41:33 UTC) #1
jameinel
LGTM maybe a comment on the test line saying "ensure that we can have some ...
10 years ago (2014-03-31 10:11:30 UTC) #2
wwitzel3
10 years ago (2014-03-31 10:29:05 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b