Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8452)

Issue 82280045: Changed timeout on mongo wait after restore

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by hduran
Modified:
10 years ago
Reviewers:
mp+214118, natefinch, rog
Visibility:
Public.

Description

Changed timeout on mongo wait after restore Bug 1291022 was caused by a race condition. After restore, there was a period of wait until mongodb would come up. The timeout value was set too low for cases where connectio to the server was too fast. On slow connections there was extra time produced by the wait for the server answer to the polling. I changed the timeout value and tested in a machine in the same region than the environment created, it stopped failing after the change. https://code.launchpad.net/~hduran-8/juju-core/1291022_remove_race_condition_waiting_machine/+merge/214118 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed timeout on mongo wait after restore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/plugins/juju-restore/restore.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
hduran
Please take a look.
10 years ago (2014-04-03 20:55:07 UTC) #1
natefinch
LGTM
10 years ago (2014-04-03 20:56:52 UTC) #2
rog
LGTM modulo the below. https://codereview.appspot.com/82280045/diff/1/cmd/plugins/juju-restore/restore.go File cmd/plugins/juju-restore/restore.go (right): https://codereview.appspot.com/82280045/diff/1/cmd/plugins/juju-restore/restore.go#newcode128 cmd/plugins/juju-restore/restore.go:128: #Used to be 2, that ...
10 years ago (2014-04-04 11:30:51 UTC) #3
hduran
10 years ago (2014-04-04 11:35:16 UTC) #4
Please take a look.

https://codereview.appspot.com/82280045/diff/1/cmd/plugins/juju-restore/resto...
File cmd/plugins/juju-restore/restore.go (right):

https://codereview.appspot.com/82280045/diff/1/cmd/plugins/juju-restore/resto...
cmd/plugins/juju-restore/restore.go:128: #Used to be 2, that is not enough when
we are too close in terms of network
On 2014/04/04 11:30:51, rog wrote:
> As suggested online, I suggest 100 iterations of 5 seconds.
> I don't think the comment adds much value FWIW.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b