Issue 8208043: code review 8208043: net/http: Transport: be paranoid about any non-100 1xx ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8208043: code review 8208043: net/http: Transport: be paranoid about any non-100 1xx ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by bradfitz

Modified:
11 years ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

net/http: Transport: be paranoid about any non-100 1xx response Since we can't properly handle anything except 100, treat all 1xx informational responses as sketchy and don't reuse the connection for future requests. The only other 1xx response code currently in use in the wild is WebSockets' use of "101 Switching Protocols", but our code.google.com/p/go.net/websockets doesn't use Client or Transport: it uses ReadResponse directly, so is unaffected by this CL. (and its tests still pass) So this CL is entirely just future-proofing paranoia. Also: the Internet is weird. Update Issue 2184 Update Issue 3665

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -17 lines)			Patch
M	src/pkg/net/http/serve_test.go	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/pkg/net/http/transport.go	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/pkg/net/http/transport_test.go	View	1 2	4 chunks	+47 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years ago (2013-03-31 01:51:00 UTC) #1

dsymonds

LGTM though ignoring any error back from NewRequest in the test makes me twitch a ...

11 years ago (2013-03-31 05:24:33 UTC) #2

bradfitz

11 years ago (2013-03-31 05:59:12 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d82ec1b4fb7a ***

net/http: Transport: be paranoid about any non-100 1xx response

Since we can't properly handle anything except 100, treat all
1xx informational responses as sketchy and don't reuse the
connection for future requests.

The only other 1xx response code currently in use in the wild
is WebSockets' use of "101 Switching Protocols", but our
code.google.com/p/go.net/websockets doesn't use Client or
Transport: it uses ReadResponse directly, so is unaffected by
this CL.  (and its tests still pass)

So this CL is entirely just future-proofing paranoia.
Also: the Internet is weird.

Update Issue 2184
Update Issue 3665

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/8208043

Expand All Messages | Collapse All Messages