Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(203)

Issue 81960043: Separate the version of .isolated and .isolated.state. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by M-A
Modified:
11 years, 3 months ago
Reviewers:
vadimsh
CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org, kbr1
Base URL:
https://code.google.com/p/swarming.client@master
Visibility:
Public.

Description

Separate the version of .isolated and .isolated.state. This permits making breaking changes to .state more easily. - Sort returned values for load_isolate_for_config(), makes result easier to read. - Add assert for ConfigSettings internal state. - Add assert for 'includes' path on Windows. - Add tests in preparation to functional changes. In fact the vast majority of this CL is test cases. R=vadimsh@chromium.org BUG=swarming:98 Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=226ab80

Patch Set 1 #

Total comments: 8

Patch Set 2 : . #

Patch Set 3 : Fixed isolate_smoke_test.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+551 lines, -104 lines) Patch
M isolate.py View 5 chunks +15 lines, -11 lines 0 comments Download
M isolate_format.py View 1 5 chunks +16 lines, -4 lines 0 comments Download
M tests/isolate_format_test.py View 10 chunks +221 lines, -43 lines 0 comments Download
M tests/isolate_smoke_test.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate_test.py View 13 chunks +298 lines, -45 lines 0 comments Download

Messages

Total messages: 4
M-A
This makes the next CL less of a code dump. I haven't completely fixed the ...
11 years, 3 months ago (2014-03-28 19:30:10 UTC) #1
vadimsh
lgtm with question https://codereview.appspot.com/81960043/diff/1/isolate.py File isolate.py (right): https://codereview.appspot.com/81960043/diff/1/isolate.py#newcode484 isolate.py:484: EXPECTED_VERSION = isolateserver.ISOLATED_FILE_VERSION + '1' What ...
11 years, 3 months ago (2014-03-28 19:51:09 UTC) #2
M-A
https://codereview.appspot.com/81960043/diff/1/isolate.py File isolate.py (right): https://codereview.appspot.com/81960043/diff/1/isolate.py#newcode484 isolate.py:484: EXPECTED_VERSION = isolateserver.ISOLATED_FILE_VERSION + '1' On 2014/03/28 19:51:09, vadimsh ...
11 years, 3 months ago (2014-03-29 02:54:52 UTC) #3
M-A
11 years, 3 months ago (2014-03-29 20:23:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r226ab80 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b