Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 81780043: Cache API server addresses in .jenv

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by axw
Modified:
10 years ago
Reviewers:
mp+213217, rog
Visibility:
Public.

Description

Cache API server addresses in .jenv We now return API server addresses from the Login API, and cache those addresses in the client's configstore. If the client connects using environments.yaml, then it is expected to get updated addresses from provider-state. https://code.launchpad.net/~axwalk/juju-core/client-cache-apihostports/+merge/213217 Requires: https://code.launchpad.net/~axwalk/juju-core/apihostports-api/+merge/213200 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 16

Patch Set 2 : Cache API server addresses in .jenv #

Total comments: 8

Patch Set 3 : Cache API server addresses in .jenv #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -109 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M juju/api.go View 1 2 13 chunks +92 lines, -42 lines 0 comments Download
M juju/apiconn_test.go View 1 2 16 chunks +58 lines, -54 lines 0 comments Download
M juju/export_test.go View 1 2 1 chunk +16 lines, -3 lines 0 comments Download
A juju/mock_test.go View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M state/api/apiclient.go View 1 2 3 chunks +25 lines, -2 lines 1 comment Download
M state/api/params/params.go View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M state/api/state.go View 1 2 2 chunks +42 lines, -1 line 0 comments Download
M state/apiserver/admin.go View 1 2 chunks +13 lines, -6 lines 0 comments Download
M state/apiserver/login_test.go View 1 2 2 chunks +71 lines, -1 line 0 comments Download

Messages

Total messages: 6
axw
Please take a look.
10 years ago (2014-03-28 09:23:41 UTC) #1
rog
Great direction, thanks, with a few suggestions below. https://codereview.appspot.com/81780043/diff/1/juju/api.go File juju/api.go (right): https://codereview.appspot.com/81780043/diff/1/juju/api.go#newcode252 juju/api.go:252: logger.Warningf(err.Error()) ...
10 years ago (2014-03-28 10:02:12 UTC) #2
axw
Please take a look. https://codereview.appspot.com/81780043/diff/1/juju/api.go File juju/api.go (right): https://codereview.appspot.com/81780043/diff/1/juju/api.go#newcode252 juju/api.go:252: logger.Warningf(err.Error()) On 2014/03/28 10:02:12, rog ...
10 years ago (2014-03-28 13:05:41 UTC) #3
rog
LGTM with the juju tests fixed so they don't rely on calling methods on the ...
10 years ago (2014-03-31 08:37:33 UTC) #4
axw
Please take a look. https://codereview.appspot.com/81780043/diff/20001/juju/apiconn_test.go File juju/apiconn_test.go (right): https://codereview.appspot.com/81780043/diff/20001/juju/apiconn_test.go#newcode160 juju/apiconn_test.go:160: // be updated (to an ...
10 years ago (2014-03-31 12:36:27 UTC) #5
rog
10 years ago (2014-03-31 14:33:07 UTC) #6
still LGTM

https://codereview.appspot.com/81780043/diff/40001/state/api/apiclient.go
File state/api/apiclient.go (right):

https://codereview.appspot.com/81780043/diff/40001/state/api/apiclient.go#new...
state/api/apiclient.go:215: hostPorts[i] = append([]instance.HostPort{},
server...)
or hostPorts[i] = append(hostPorts[i], server...)
(slightly shorter)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b