Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(222)

Issue 81660043: code review 81660043: ogle: fork all the debug packages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by r
Modified:
7 years, 8 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle: fork all the debug packages They are interrelated and it's cleaner to separate them out for hackery.

Patch Set 1 #

Patch Set 2 : diff -r ecb70517b100 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3950 lines, -5 lines) Patch
M debug/dwarf/type.go View 1 chunk +2 lines, -2 lines 0 comments Download
M debug/dwarf/type_test.go View 1 chunk +4 lines, -3 lines 0 comments Download
A debug/elf/elf.go View 1 chunk +1521 lines, -0 lines 0 comments Download
A debug/elf/elf_test.go View 1 chunk +49 lines, -0 lines 0 comments Download
A debug/elf/file.go View 1 chunk +828 lines, -0 lines 0 comments Download
A debug/elf/file_test.go View 1 chunk +334 lines, -0 lines 0 comments Download
A debug/elf/testdata/gcc-386-freebsd-exec View Binary file 0 comments Download
A debug/elf/testdata/gcc-amd64-linux-exec View Binary file 0 comments Download
A debug/elf/testdata/gcc-amd64-openbsd-debug-with-rela.obj View Binary file 0 comments Download
A debug/elf/testdata/go-relocation-test-gcc424-x86-64.obj View Binary file 0 comments Download
A debug/elf/testdata/go-relocation-test-gcc441-x86.obj View Binary file 0 comments Download
A debug/elf/testdata/go-relocation-test-gcc441-x86-64.obj View Binary file 0 comments Download
A debug/elf/testdata/hello.c View 1 chunk +7 lines, -0 lines 0 comments Download
A debug/elf/testdata/hello-world-core.gz View Binary file 0 comments Download
A debug/macho/fat.go View 1 chunk +146 lines, -0 lines 0 comments Download
A debug/macho/file.go View 1 chunk +525 lines, -0 lines 0 comments Download
A debug/macho/file_test.go View 1 chunk +210 lines, -0 lines 0 comments Download
A debug/macho/macho.go View 1 chunk +316 lines, -0 lines 0 comments Download
A debug/macho/testdata/fat-gcc-386-amd64-darwin-exec View Binary file 0 comments Download
A debug/macho/testdata/gcc-386-darwin-exec View Binary file 0 comments Download
A debug/macho/testdata/gcc-amd64-darwin-exec View Binary file 0 comments Download
A debug/macho/testdata/gcc-amd64-darwin-exec-debug View Binary file 0 comments Download
A debug/macho/testdata/hello.c View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 8 months ago (2014-03-28 01:54:02 UTC) #1
nigeltao
LGTM.
7 years, 8 months ago (2014-03-28 01:55:07 UTC) #2
r
7 years, 8 months ago (2014-03-28 01:56:38 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=fa703e07914d ***

ogle: fork all the debug packages
They are interrelated and it's cleaner to separate them out for hackery.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/81660043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b