Issue 81640043: code review 81640043: ogle: copy debug/dwarf into our repo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81640043: code review 81640043: ogle: copy debug/dwarf into our repo (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by r

Modified:
10 years ago

Reviewers:
nigeltao

CC:
nigeltao

Visibility:
Public.

Description

ogle: copy debug/dwarf into our repo We will need to make changes, so have a local copy.

Patch Set 1 #

Patch Set 2 : diff -r b0fd2d1d31aa https://code.google.com/p/ogle #

Patch Set 3 : diff -r b0fd2d1d31aa https://code.google.com/p/ogle #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2245 lines, -0 lines)			Patch
A	debug/dwarf/buf.go	View	1 chunk	+181 lines, -0 lines	0 comments	Download
A	debug/dwarf/const.go	View	1 chunk	+454 lines, -0 lines	0 comments	Download
A	debug/dwarf/entry.go	View	1 chunk	+401 lines, -0 lines	0 comments	Download
A	debug/dwarf/open.go	View	1 chunk	+87 lines, -0 lines	0 comments	Download
A	debug/dwarf/testdata/typedef.c	View	1 chunk	+85 lines, -0 lines	0 comments	Download
A	debug/dwarf/testdata/typedef.elf	View	Binary file		0 comments	Download
A	debug/dwarf/testdata/typedef.elf4	View	Binary file		0 comments	Download
A	debug/dwarf/testdata/typedef.macho	View	Binary file		0 comments	Download
A	debug/dwarf/type.go	View	1 chunk	+659 lines, -0 lines	0 comments	Download
A	debug/dwarf/type_test.go	View	1 chunk	+122 lines, -0 lines	0 comments	Download
A	debug/dwarf/typeunit.go	View	1 chunk	+166 lines, -0 lines	0 comments	Download
A	debug/dwarf/unit.go	View	1 chunk	+90 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle

10 years ago (2014-03-28 01:32:33 UTC) #1

10 years ago (2014-03-28 01:40:39 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=ecb70517b100 ***

ogle: copy debug/dwarf into our repo
We will need to make changes, so have a local copy.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/81640043

Expand All Messages | Collapse All Messages