Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(202)

Issue 81640043: code review 81640043: ogle: copy debug/dwarf into our repo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by r
Modified:
7 years, 8 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle: copy debug/dwarf into our repo We will need to make changes, so have a local copy.

Patch Set 1 #

Patch Set 2 : diff -r b0fd2d1d31aa https://code.google.com/p/ogle #

Patch Set 3 : diff -r b0fd2d1d31aa https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2245 lines, -0 lines) Patch
A debug/dwarf/buf.go View 1 chunk +181 lines, -0 lines 0 comments Download
A debug/dwarf/const.go View 1 chunk +454 lines, -0 lines 0 comments Download
A debug/dwarf/entry.go View 1 chunk +401 lines, -0 lines 0 comments Download
A debug/dwarf/open.go View 1 chunk +87 lines, -0 lines 0 comments Download
A debug/dwarf/testdata/typedef.c View 1 chunk +85 lines, -0 lines 0 comments Download
A debug/dwarf/testdata/typedef.elf View Binary file 0 comments Download
A debug/dwarf/testdata/typedef.elf4 View Binary file 0 comments Download
A debug/dwarf/testdata/typedef.macho View Binary file 0 comments Download
A debug/dwarf/type.go View 1 chunk +659 lines, -0 lines 0 comments Download
A debug/dwarf/type_test.go View 1 chunk +122 lines, -0 lines 0 comments Download
A debug/dwarf/typeunit.go View 1 chunk +166 lines, -0 lines 0 comments Download
A debug/dwarf/unit.go View 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 8 months ago (2014-03-28 01:32:33 UTC) #1
nigeltao
LGTM.
7 years, 8 months ago (2014-03-28 01:37:26 UTC) #2
r
7 years, 8 months ago (2014-03-28 01:40:39 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=ecb70517b100 ***

ogle: copy debug/dwarf into our repo
We will need to make changes, so have a local copy.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/81640043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b