Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(474)

Issue 81580044: code review 81580044: ogle/program: add Frames protocol, to print function ar... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by nigeltao
Modified:
7 years, 8 months ago
Reviewers:
r
CC:
r
Visibility:
Public.

Description

ogle/program: add Frames protocol, to print function arguments.

Patch Set 1 #

Patch Set 2 : diff -r 169ddd453781 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 169ddd453781 https://code.google.com/p/ogle #

Patch Set 4 : diff -r 169ddd453781 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -18 lines) Patch
M program/client/client.go View 1 1 chunk +9 lines, -0 lines 0 comments Download
M program/program.go View 1 2 chunks +8 lines, -0 lines 0 comments Download
M program/proxyrpc/proxyrpc.go View 1 1 chunk +8 lines, -0 lines 0 comments Download
M program/server/dwarf.go View 1 3 chunks +27 lines, -18 lines 0 comments Download
M program/server/server.go View 1 2 chunks +80 lines, -0 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 8 months ago (2014-03-28 04:47:28 UTC) #1
r
LGTM
7 years, 8 months ago (2014-03-28 04:48:18 UTC) #2
nigeltao
7 years, 8 months ago (2014-03-28 04:48:50 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=8e5b1296ed0e ***

ogle/program: add Frames protocol, to print function arguments.

LGTM=r
R=r
https://codereview.appspot.com/81580044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b