Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(845)

Issue 81570045: cleanup: fixing go vet warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by wwitzel
Modified:
6 years, 6 months ago
Reviewers:
wwitzel3, mp+213235, rog
Visibility:
Public.

Description

cleanup: fixing go vet warnings Cleanup of go vet warnings. https://code.launchpad.net/~wwitzel3/juju-core/001-go-vet-cleanup/+merge/213235 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : cleanup: fixing go vet warnings #

Patch Set 3 : cleanup: fixing go vet warnings #

Patch Set 4 : cleanup: fixing go vet warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -49 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/addmachine.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/bootstrap.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/deploy.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/plugin.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/publish.go View 1 chunk +0 lines, -1 line 0 comments Download
M cmd/jujud/bootstrap.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/plugins/juju-restore/restore.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/imagemetadata/generate.go View 1 1 chunk +4 lines, -1 line 0 comments Download
M environs/imagemetadata/validation.go View 1 1 chunk +7 lines, -4 lines 0 comments Download
M environs/tools/validation.go View 1 3 chunks +17 lines, -7 lines 0 comments Download
M juju/arch/arch.go View 1 chunk +0 lines, -1 line 0 comments Download
M provider/azure/instance.go View 1 chunk +11 lines, -5 lines 0 comments Download
M state/apiserver/charmrevisionupdater/updater.go View 1 chunk +4 lines, -4 lines 0 comments Download
M state/apiserver/keymanager/keymanager.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/keyupdater/authorisedkeys.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/apiserver/logger/logger.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/apiserver/upgrader/unitupgrader.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/upgrader/upgrader.go View 1 chunk +1 line, -1 line 0 comments Download
M state/presence/presence.go View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M state/watcher.go View 7 chunks +0 lines, -7 lines 0 comments Download
M state/watcher/watcher.go View 1 chunk +1 line, -1 line 0 comments Download
M store/store.go View 1 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 5
wwitzel
Please take a look.
6 years, 6 months ago (2014-03-28 11:29:59 UTC) #1
rog
LGTM with a suggestion. https://codereview.appspot.com/81570045/diff/1/environs/imagemetadata/validation.go File environs/imagemetadata/validation.go (right): https://codereview.appspot.com/81570045/diff/1/environs/imagemetadata/validation.go#newcode31 environs/imagemetadata/validation.go:31: CloudSpec: simplestreams.CloudSpec{Region: params.Region, Endpoint: params.Endpoint}, ...
6 years, 6 months ago (2014-03-28 11:44:42 UTC) #2
wwitzel
Please take a look.
6 years, 6 months ago (2014-03-28 11:56:01 UTC) #3
wwitzel3
https://codereview.appspot.com/81570045/diff/1/environs/imagemetadata/validation.go File environs/imagemetadata/validation.go (right): https://codereview.appspot.com/81570045/diff/1/environs/imagemetadata/validation.go#newcode31 environs/imagemetadata/validation.go:31: CloudSpec: simplestreams.CloudSpec{Region: params.Region, Endpoint: params.Endpoint}, On 2014/03/28 11:44:42, rog ...
6 years, 6 months ago (2014-03-28 11:56:14 UTC) #4
wwitzel
6 years, 6 months ago (2014-03-28 16:32:58 UTC) #5
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b