Issue 81320044: Enforce sorted Configs.config_variables.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81320044: Enforce sorted Configs.config_variables. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by M-A

Modified:
11 years, 3 months ago

Reviewers:
vadimsh

CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org

Base URL:
https://code.google.com/p/swarming.client@master

Visibility:
Public.

More Reviews

Description

Enforce sorted Configs.config_variables. This helps in making Configs behavior more deterministic. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=f0d0787

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -13 lines)			Patch
	M	isolate_format.py	View		3 chunks	+7 lines, -1 line	0 comments	Download
	M	tests/isolate_format_test.py	View		1 chunk	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

M-A

11 years, 3 months ago (2014-03-27 20:59:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rf0d0787 (presubmit successful).

Expand All Messages | Collapse All Messages