Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(273)

Issue 813048: Change lilypond-book's LaTeX environment option placement (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by dak
Modified:
7 years, 3 months ago
Reviewers:
carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Change lilypond-book's LaTeX environment option placement This changes the documented option placement for LaTeX "lilypond" environments in lilypond-book mode to have the options after the environment name, like customary with LaTeX environments. lilypond-book is adapted to accept both previous and new order.

Patch Set 1 #

Patch Set 2 : Fix documentation translations and examples. #

Patch Set 3 : Add changelog entry. #

Total comments: 2

Patch Set 4 : Fix last change which got the new syntax example wrong. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -30 lines) Patch
M Documentation/changes.tely View 3 1 chunk +16 lines, -0 lines 0 comments Download
M Documentation/de/usage/lilypond-book.itely View 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/es/usage/lilypond-book.itely View 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/ja/usage/lilypond-book.itely View 4 chunks +4 lines, -4 lines 0 comments Download
Documentation/usage/latex-example.latex View 1 chunk +1 line, -1 line 0 comments Download
Documentation/usage/latex-lilypond-example.latex View 5 chunks +10 lines, -10 lines 0 comments Download
M Documentation/usage/lilypond-book.itely View 1 5 chunks +5 lines, -5 lines 0 comments Download
M scripts/lilypond-book.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
Carl
LGTM. Thanks for getting us in line with standards. Carl http://codereview.appspot.com/813048/diff/5001/6001 File Documentation/changes.tely (right): http://codereview.appspot.com/813048/diff/5001/6001#newcode72 ...
8 years, 3 months ago (2010-04-20 13:02:15 UTC) #1
dak
Amended. http://codereview.appspot.com/813048/diff/5001/6001 File Documentation/changes.tely (right): http://codereview.appspot.com/813048/diff/5001/6001#newcode72 Documentation/changes.tely:72: @example On 2010/04/20 13:02:15, Carl wrote: > I ...
8 years, 3 months ago (2010-04-20 13:19:59 UTC) #2
Graham Percival
On Tue, Apr 20, 2010 at 2:19 PM, <dak@gnu.org> wrote: > http://codereview.appspot.com/813048/diff/5001/6001#newcode72 > Documentation/changes.tely:72: @example ...
8 years, 3 months ago (2010-04-20 13:57:28 UTC) #3
c_sorensen
On 4/20/10 7:57 AM, "Graham Percival" <graham@percival-music.ca> wrote: > On Tue, Apr 20, 2010 at ...
8 years, 3 months ago (2010-04-20 14:10:46 UTC) #4
c_sorensen
On 4/20/10 7:57 AM, "Graham Percival" <graham@percival-music.ca> wrote: > On Tue, Apr 20, 2010 at ...
8 years, 3 months ago (2010-04-20 14:12:35 UTC) #5
Graham Percival
On Tue, Apr 20, 2010 at 08:10:15AM -0600, Carl Sorensen wrote: > > On 4/20/10 ...
8 years, 3 months ago (2010-04-20 16:05:16 UTC) #6
dak
8 years, 3 months ago (2010-04-20 21:23:13 UTC) #7
Graham Percival <graham@percival-music.ca> writes:

> On Tue, Apr 20, 2010 at 08:10:15AM -0600, Carl Sorensen wrote:
>> 
>> On 4/20/10 7:57 AM, "Graham Percival" <graham@percival-music.ca> wrote:
>> 
>> > Once it *is* tested, does anybody know how to apply the
>> > patch?  I see a "download raw patch set", but we should obviously keep
>> > David's name and changelog entries.  I feel as though I'm missing
>> > something obvious, but I've spent a few minutes poking around on
>> > Rietveld without finding anything.
>> 
>> Download the raw patch set.
>> 
>> Then apply it to your repository:
>> git apply downloaded-patch
>> git commit -a --author="David A. Kastrup <dak@gnu.ork>"
>
> Ick.  I came up with something like that myself (although I used
> patch -p1 < downloaded-patch  ), but I figured there had to be a
> better way.  Oh well.

Sure.  Commit access for David.  But I don't see that the Rietveld
process facilitates a reasonable workflow for non-committers.

If they posted patch series on the list, one could fetch them using git
am.

git cl has a subcommand patch.  Maybe that helps?

-- 
David Kastrup
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b