Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 81240045: code review 81240045: ogle/program/server: use dwarf data directly, instead o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by nigeltao
Modified:
7 years, 8 months ago
Reviewers:
r
CC:
r
Visibility:
Public.

Description

ogle/program/server: use dwarf data directly, instead of gosym.

Patch Set 1 #

Patch Set 2 : diff -r fa703e07914d https://code.google.com/p/ogle #

Patch Set 3 : diff -r fa703e07914d https://code.google.com/p/ogle #

Total comments: 2

Patch Set 4 : diff -r fa703e07914d https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -89 lines) Patch
A program/server/dwarf.go View 1 chunk +164 lines, -0 lines 0 comments Download
M program/server/server.go View 7 chunks +24 lines, -89 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 8 months ago (2014-03-28 03:20:32 UTC) #1
r
LGTM https://codereview.appspot.com/81240045/diff/40001/program/server/dwarf.go File program/server/dwarf.go (right): https://codereview.appspot.com/81240045/diff/40001/program/server/dwarf.go#newcode1 program/server/dwarf.go:1: package server copyright https://codereview.appspot.com/81240045/diff/40001/program/server/dwarf.go#newcode115 program/server/dwarf.go:115: func evalDwarf(v []uint8) ...
7 years, 8 months ago (2014-03-28 03:23:43 UTC) #2
nigeltao
7 years, 8 months ago (2014-03-28 03:43:53 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=169ddd453781 ***

ogle/program/server: use dwarf data directly, instead of gosym.

LGTM=r
R=r
https://codereview.appspot.com/81240045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b