Issue 81240045: code review 81240045: ogle/program/server: use dwarf data directly, instead o...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81240045: code review 81240045: ogle/program/server: use dwarf data directly, instead o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by nigeltao

Modified:
10 years ago

Reviewers:
r

CC:
r

Visibility:
Public.

Description

ogle/program/server: use dwarf data directly, instead of gosym.

Patch Set 2 : diff -r fa703e07914d https://code.google.com/p/ogle #

Patch Set 3 : diff -r fa703e07914d https://code.google.com/p/ogle #

Total comments: 2

Patch Set 4 : diff -r fa703e07914d https://code.google.com/p/ogle #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -89 lines)			Patch
	A	program/server/dwarf.go	View		1 chunk	+164 lines, -0 lines	0 comments	Download
	M	program/server/server.go	View		7 chunks	+24 lines, -89 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle

10 years ago (2014-03-28 03:20:32 UTC) #1

LGTM https://codereview.appspot.com/81240045/diff/40001/program/server/dwarf.go File program/server/dwarf.go (right): https://codereview.appspot.com/81240045/diff/40001/program/server/dwarf.go#newcode1 program/server/dwarf.go:1: package server copyright https://codereview.appspot.com/81240045/diff/40001/program/server/dwarf.go#newcode115 program/server/dwarf.go:115: func evalDwarf(v []uint8) ...

10 years ago (2014-03-28 03:23:43 UTC) #2

nigeltao

10 years ago (2014-03-28 03:43:53 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=169ddd453781 ***

ogle/program/server: use dwarf data directly, instead of gosym.

LGTM=r
R=r
https://codereview.appspot.com/81240045

Expand All Messages | Collapse All Messages