Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(964)

Issue 8079043: Simplify some complicated code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by wallyworld
Modified:
10 years, 11 months ago
Reviewers:
mp+155950, jameinel, dimitern
Visibility:
Public.

Description

Simplify some complicated code This branch cleans up some complicated code which was left after a previous branch landed. https://code.launchpad.net/~wallyworld/goose/region-error-fixups/+merge/155950 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -22 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M client/client.go View 4 chunks +37 lines, -19 lines 2 comments Download
M client/local_test.go View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
wallyworld
Please take a look.
11 years ago (2013-03-28 12:38:37 UTC) #1
dimitern
Thank you! LGTM.
11 years ago (2013-03-28 12:43:05 UTC) #2
jameinel
This is the current error: $ juju bootstrap -e hp-jam error: cannot query old bootstrap ...
11 years ago (2013-03-28 12:48:09 UTC) #3
wallyworld
11 years ago (2013-03-28 12:53:43 UTC) #4
https://codereview.appspot.com/8079043/diff/1/client/client.go
File client/client.go (right):

https://codereview.appspot.com/8079043/diff/1/client/client.go#newcode238
client/client.go:238: var serviceTypeRegions map[string][]string
On 2013/03/28 12:48:09, jameinel wrote:
> I thought you had to use make() otherwise you end up with a nil map, which
> doesn't allow you to add items.
> But I tested, and it clearly works.

The var is just declared here, make is done inside the method which populates
the map
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b