Issue 79730043: uniter/charm: rearrange, add Bundle interface

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by fwereade

Modified:
10 years ago

Reviewers:
dimitern, mp+212566

Visibility:
Public.

Description

uniter/charm: rearrange, add Bundle interface This is more supporting work to enable an imminent manifest-based deployer. https://code.launchpad.net/~fwereade/juju-core/uniter-charm-refactor-again/+merge/212566 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 9

Patch Set 2 : uniter/charm: rearrange, add Bundle interface #

Patch Set 3 : uniter/charm: rearrange, add Bundle interface #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+284 lines, -192 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/uniter/charm/bundles.go	View	1 2	6 chunks	+12 lines, -30 lines	0 comments	Download
M	worker/uniter/charm/bundles_test.go	View		4 chunks	+6 lines, -10 lines	0 comments	Download
A	worker/uniter/charm/charm.go	View	1 2	1 chunk	+100 lines, -0 lines	0 comments	Download
A	worker/uniter/charm/charm_test.go	View		1 chunk	+89 lines, -0 lines	0 comments	Download
M	worker/uniter/charm/export_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/uniter/charm/git.go	View	1 2	4 chunks	+9 lines, -18 lines	0 comments	Download
M	worker/uniter/charm/git_deployer.go	View	1 2	10 chunks	+44 lines, -63 lines	0 comments	Download
M	worker/uniter/charm/git_deployer_test.go	View		10 chunks	+17 lines, -66 lines	0 comments	Download
M	worker/uniter/charm/git_test.go	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

Great direction! Some thoughts below: https://codereview.appspot.com/79730043/diff/1/worker/uniter/charm/charm.go File worker/uniter/charm/charm.go (right): https://codereview.appspot.com/79730043/diff/1/worker/uniter/charm/charm.go#newcode1 worker/uniter/charm/charm.go:1: // Copyright 2012-2014 Canonical ...

10 years ago (2014-03-25 09:45:47 UTC) #2

fwereade

Please take a look. https://codereview.appspot.com/79730043/diff/1/worker/uniter/charm/charm.go File worker/uniter/charm/charm.go (right): https://codereview.appspot.com/79730043/diff/1/worker/uniter/charm/charm.go#newcode1 worker/uniter/charm/charm.go:1: // Copyright 2012-2014 Canonical Ltd. ...

10 years ago (2014-03-25 10:13:28 UTC) #3

dimitern

10 years ago (2014-03-25 10:16:35 UTC) #4

LGTM, thanks!

https://codereview.appspot.com/79730043/diff/1/worker/uniter/charm/charm.go
File worker/uniter/charm/charm.go (right):

https://codereview.appspot.com/79730043/diff/1/worker/uniter/charm/charm.go#n...
worker/uniter/charm/charm.go:1: // Copyright 2012-2014 Canonical Ltd.
On 2014/03/25 10:13:28, fwereade wrote:
> On 2014/03/25 09:45:48, dimitern wrote:
> > I'd just go with 2014 here.
> 
> Ehh, it's all a mix of code from 2012-2014. I was actually planning to update
> them all to say this.

Fair enough, but some day we should get a *definite* answer from legal how
should we format copyright lines with years.

Expand All Messages | Collapse All Messages