Issue 7963043: Retain traling slashes on URLs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7963043: Retain traling slashes on URLs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by wallyworld

Modified:
11 years, 1 month ago

Reviewers:
gz, mp+154876, jameinel

Visibility:
Public.

Description

Retain traling slashes on URLs When the final URL for the request was being constructed, all trailing slashes were being stripped, even if the URL was supposed to have one. https://code.launchpad.net/~wallyworld/goose/retain-trailing-slashes/+merge/154876 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -18 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/client.go	View	3 chunks	+9 lines, -8 lines	2 comments	Download
M	client/local_test.go	View	3 chunks	+22 lines, -3 lines	0 comments	Download
M	nova/nova.go	View	1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jameinel

LGTM https://codereview.appspot.com/7963043/diff/1/client/client.go File client/client.go (right): https://codereview.appspot.com/7963043/diff/1/client/client.go#newcode119 client/client.go:119: } Definitely nice to see a common helper ...

11 years, 1 month ago (2013-03-22 17:18:18 UTC) #2

11 years, 1 month ago (2013-03-24 15:10:44 UTC) #3

LGTM

https://codereview.appspot.com/7963043/diff/1/client/client.go
File client/client.go (right):

https://codereview.appspot.com/7963043/diff/1/client/client.go#newcode114
client/client.go:114: func makeURL(base string, parts []string) string {
Certainly an improvement on using path.Join though it seems like we may have
more fun in the future from not having robust url handling.

Expand All Messages | Collapse All Messages