Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17386)

Issue 79620043: provider/local: use "env" to propagate JUJU_HOME

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by axw
Modified:
10 years ago
Reviewers:
mp+212538, thumper
Visibility:
Public.

Description

provider/local: use "env" to propagate JUJU_HOME Sudo may not allow environment variables to be set directly, so we must use "env" to set JUJU_HOME when re-executing juju as root. Fixes lp:1296739 https://code.launchpad.net/~axwalk/juju-core/lp1296739-local-sudo-env/+merge/212538 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M provider/local/environ.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/local/environ_test.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
axw
Please take a look.
10 years ago (2014-03-25 02:53:32 UTC) #1
thumper
10 years ago (2014-03-25 03:29:54 UTC) #2
On 2014/03/25 02:53:32, axw wrote:
> Please take a look.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b