Issue 7951043: code review 7951043: go/doc: use regexp for -notes instead of comma-sep. list

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7951043: code review 7951043: go/doc: use regexp for -notes instead of comma-sep. list (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by gri

Modified:
12 years, 1 month ago

Reviewers:

CC:
cnicolaou, golang-dev

Visibility:
Public.

Description

go/doc: use regexp for -notes instead of comma-sep. list -notes="BUG|TODO" instead of -notes="BUG,TODO". Permits -notes=".*" to see all notes.

Patch Set 1 #

Patch Set 2 : diff -r b0ff2babd1f5 https://code.google.com/p/go #

Patch Set 3 : diff -r b0ff2babd1f5 https://code.google.com/p/go #

Patch Set 4 : diff -r a78557354dc0 https://code.google.com/p/go #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	src/cmd/godoc/doc.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/cmd/godoc/godoc.go	View	1	2 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello cnicolaou@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 1 month ago (2013-03-21 18:40:44 UTC) #1

gri

12 years, 1 month ago (2013-03-21 22:56:31 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=8e013d7f67a4 ***

go/doc: use regexp for -notes instead of comma-sep. list

-notes="BUG|TODO" instead of -notes="BUG,TODO".
Permits -notes=".*" to see all notes.

R=cnicolaou
CC=golang-dev
https://codereview.appspot.com/7951043

Expand All Messages | Collapse All Messages