Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 7904043: code review 7904043: go.exp/locale/collate: changed maketables.go to make us... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by mpvl
Modified:
11 years ago
Reviewers:
CC:
r, mpvl_google.com, golang-dev
Visibility:
Public.

Description

go.exp/locale/collate: changed maketables.go to make use of new cldr package. This fixes several bugs in tables.go and chars.go that were related to not correctly handling LDML inheritance.

Patch Set 1 #

Patch Set 2 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Patch Set 3 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Patch Set 4 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Patch Set 5 : diff -r e820b1175f13 https://code.google.com/p/go.exp/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -374 lines) Patch
M locale/collate/maketables.go View 1 2 3 4 10 chunks +91 lines, -243 lines 0 comments Download
M locale/collate/tools/colcmp/Makefile View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M locale/collate/tools/colcmp/chars.go View 1 2 3 4 4 chunks +342 lines, -130 lines 0 comments Download

Messages

Total messages: 5
mpvl
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.exp/
11 years ago (2013-03-19 13:23:50 UTC) #1
r
LGTM (although a little more function-level commentary wouldn't hurt) of course we need to land ...
11 years ago (2013-03-19 18:29:03 UTC) #2
mpvl_google.com
updated comments for the altInclude function at least. On Tue, Mar 19, 2013 at 7:29 ...
11 years ago (2013-03-20 13:42:20 UTC) #3
r
LGTM still
11 years ago (2013-03-20 17:32:07 UTC) #4
mpvl
11 years ago (2013-03-27 12:00:36 UTC) #5
*** Submitted as
https://code.google.com/p/go/source/detail?r=2d7795660ea0&repo=exp ***

go.exp/locale/collate: changed maketables.go to make use of new cldr
package.  This fixes several bugs in tables.go and chars.go that were
related to not correctly handling LDML inheritance.

R=r, mpvl
CC=golang-dev
https://codereview.appspot.com/7904043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b