Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(315)

Issue 7903043: code review 7903043: go.exp/locale/cldr: Core implementation of cldr package: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by mpvl
Modified:
8 years, 10 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

go.exp/locale/cldr: Core implementation of cldr package: - cldr.go: main API - resolve.go: code for resolving inheritance and aliases - decode.go: loading from directory or zip file. - examples

Patch Set 1 #

Patch Set 2 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Patch Set 3 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Patch Set 4 : diff -r cf222d8ab73e https://code.google.com/p/go.exp/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1430 lines, -0 lines) Patch
A locale/cldr/cldr.go View 1 1 chunk +104 lines, -0 lines 0 comments Download
A locale/cldr/data_test.go View 1 1 chunk +186 lines, -0 lines 0 comments Download
A locale/cldr/decode.go View 1 1 chunk +169 lines, -0 lines 0 comments Download
A locale/cldr/resolve.go View 1 1 chunk +603 lines, -0 lines 0 comments Download
A locale/cldr/resolve_test.go View 1 1 chunk +368 lines, -0 lines 0 comments Download

Messages

Total messages: 3
mpvl
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.exp/
8 years, 10 months ago (2013-03-19 12:57:52 UTC) #1
r
LGTM
8 years, 10 months ago (2013-03-21 19:24:07 UTC) #2
mpvl
8 years, 10 months ago (2013-03-25 19:14:54 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=3167cd2c7dd4&repo=exp ***

go.exp/locale/cldr: Core implementation of cldr package:
 - cldr.go: main API
 - resolve.go: code for resolving inheritance and aliases
 - decode.go: loading from directory or zip file.
 - examples

R=r
CC=golang-dev
https://codereview.appspot.com/7903043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b