Issue 7903043: code review 7903043: go.exp/locale/cldr: Core implementation of cldr package:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7903043: code review 7903043: go.exp/locale/cldr: Core implementation of cldr package: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by mpvl

Modified:
11 years, 1 month ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go.exp/locale/cldr: Core implementation of cldr package: - cldr.go: main API - resolve.go: code for resolving inheritance and aliases - decode.go: loading from directory or zip file. - examples

Patch Set 1 #

Patch Set 2 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Patch Set 3 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Patch Set 4 : diff -r cf222d8ab73e https://code.google.com/p/go.exp/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1430 lines, -0 lines)			Patch
A	locale/cldr/cldr.go	View	1	1 chunk	+104 lines, -0 lines	0 comments	Download
A	locale/cldr/data_test.go	View	1	1 chunk	+186 lines, -0 lines	0 comments	Download
A	locale/cldr/decode.go	View	1	1 chunk	+169 lines, -0 lines	0 comments	Download
A	locale/cldr/resolve.go	View	1	1 chunk	+603 lines, -0 lines	0 comments	Download
A	locale/cldr/resolve_test.go	View	1	1 chunk	+368 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mpvl

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.exp/

11 years, 1 month ago (2013-03-19 12:57:52 UTC) #1

mpvl

11 years, 1 month ago (2013-03-25 19:14:54 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=3167cd2c7dd4&repo=exp ***

go.exp/locale/cldr: Core implementation of cldr package:
 - cldr.go: main API
 - resolve.go: code for resolving inheritance and aliases
 - decode.go: loading from directory or zip file.
 - examples

R=r
CC=golang-dev
https://codereview.appspot.com/7903043

Expand All Messages | Collapse All Messages