Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(902)

Issue 78530044: code review 78530044: ogle/program: first cut of breakpoint support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by nigeltao
Modified:
7 years, 10 months ago
Reviewers:
r
CC:
r
Visibility:
Public.

Description

ogle/program: first cut of breakpoint support.

Patch Set 1 #

Patch Set 2 : diff -r ad2f0964d3f5 https://code.google.com/p/ogle #

Patch Set 3 : diff -r ad2f0964d3f5 https://code.google.com/p/ogle #

Total comments: 2

Patch Set 4 : diff -r ad2f0964d3f5 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -15 lines) Patch
M program/client/client.go View 1 3 chunks +21 lines, -3 lines 0 comments Download
M program/program.go View 1 1 chunk +1 line, -1 line 0 comments Download
M program/proxyrpc/proxyrpc.go View 1 2 chunks +24 lines, -0 lines 0 comments Download
A program/server/ptrace.go View 1 2 3 1 chunk +96 lines, -0 lines 0 comments Download
M program/server/server.go View 1 7 chunks +164 lines, -11 lines 0 comments Download

Messages

Total messages: 4
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 10 months ago (2014-03-21 05:58:08 UTC) #1
r
LGTM https://codereview.appspot.com/78530044/diff/40001/program/server/ptrace.go File program/server/ptrace.go (right): https://codereview.appspot.com/78530044/diff/40001/program/server/ptrace.go#newcode18 program/server/ptrace.go:18: // are returned on ec. Both channels must ...
7 years, 10 months ago (2014-03-21 07:09:52 UTC) #2
nigeltao
https://codereview.appspot.com/78530044/diff/40001/program/server/ptrace.go File program/server/ptrace.go (right): https://codereview.appspot.com/78530044/diff/40001/program/server/ptrace.go#newcode18 program/server/ptrace.go:18: // are returned on ec. Both channels must be ...
7 years, 10 months ago (2014-03-21 23:15:36 UTC) #3
nigeltao
7 years, 10 months ago (2014-03-21 23:17:56 UTC) #4
*** Submitted as https://code.google.com/p/ogle/source/detail?r=d498f00956d1 ***

ogle/program: first cut of breakpoint support.

LGTM=r
R=r
https://codereview.appspot.com/78530044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b