Issue 7849047: code review 7849047: runtime: free map structures more aggressively

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7849047: code review 7849047: runtime: free map structures more aggressively (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by khr

Modified:
12 years, 1 month ago

Reviewers:

CC:
rsc, bradfitz, khr1, golang-dev

Visibility:
Public.

Description

runtime: free map structures more aggressively

Patch Set 2 : diff -r 0fce55d10d18 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0fce55d10d18 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 85b1cc5d35dd https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -12 lines)			Patch
	M	src/pkg/runtime/hashmap.c	View	1 2 3	8 chunks	+50 lines, -12 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

khr

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-03-20 22:24:58 UTC) #1

bradfitz

https://codereview.appspot.com/7849047/diff/4001/src/pkg/runtime/hashmap.c File src/pkg/runtime/hashmap.c (right): https://codereview.appspot.com/7849047/diff/4001/src/pkg/runtime/hashmap.c#newcode403 src/pkg/runtime/hashmap.c:403: if((h->flags & (OldIterator & CanFreeBucket)) == CanFreeBucket) { did ...

12 years, 1 month ago (2013-03-20 22:28:45 UTC) #2

rsc

LGTM https://codereview.appspot.com/7849047/diff/4001/src/pkg/runtime/hashmap.c File src/pkg/runtime/hashmap.c (right): https://codereview.appspot.com/7849047/diff/4001/src/pkg/runtime/hashmap.c#newcode403 src/pkg/runtime/hashmap.c:403: if((h->flags & (OldIterator & CanFreeBucket)) == CanFreeBucket) { ...

12 years, 1 month ago (2013-03-20 22:30:07 UTC) #3

khr1

On Wed, Mar 20, 2013 at 3:28 PM, <bradfitz@golang.org> wrote: > > https://codereview.appspot.**com/7849047/diff/4001/src/pkg/** > runtime/hashmap.c<https://codereview.appspot.com/7849047/diff/4001/src/pkg/runtime/hashmap.c> ...

12 years, 1 month ago (2013-03-20 22:32:12 UTC) #4

khr

12 years, 1 month ago (2013-03-20 22:38:54 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=3df97ccfe7af ***

runtime: free map structures more aggressively

R=rsc, bradfitz, khr
CC=golang-dev
https://codereview.appspot.com/7849047

Expand All Messages | Collapse All Messages