Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 78210043: Fix a misconfiguration in swarming.py. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by M-A
Modified:
11 years, 4 months ago
Reviewers:
csharp
CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org
Base URL:
https://code.google.com/p/swarming.client@master
Visibility:
Public.

Description

Fix a misconfiguration in swarming.py. The TestObject expects a hard_time_out or io_time_out, not time_out. This parameter has been ignored up to now. It's harmless but not useful. It is now visible in the server's logs since the server noew prints out unknown parameters since ef024b615ec50539f85f4cd2409296ce229a752b. R=csharp@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=af78a90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M swarming.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/swarming_test.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
M-A
11 years, 4 months ago (2014-03-20 13:44:51 UTC) #1
csharp
lgtm
11 years, 4 months ago (2014-03-20 14:39:26 UTC) #2
M-A
11 years, 4 months ago (2014-03-20 14:43:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as raf78a90 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b