Issue 78046: Getting rid of local Django copy and release subdir

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 78046: Getting rid of local Django copy and release subdir (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 12 months ago by GvR

Modified:
16 years, 10 months ago

Reviewers:
Andi Albrecht, JohnA

Base URL:
http://rietveld.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : update README too #

Patch Set 3 : kill index.yaml #

Total comments: 3

Patch Set 4 : update the README #

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -299 lines)			Patch
M	.	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Makefile	View	2 3	1 chunk	+2 lines, -5 lines	0 comments	Download
M	README	View	2 3	2 chunks	+22 lines, -5 lines	0 comments	Download
M	app.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	main.py	View	2 3	1 chunk	+4 lines, -10 lines	0 comments	Download
D	make_release.sh	View		1 chunk	+0 lines, -54 lines	0 comments	Download
D	rietveld.py	View		1 chunk	+0 lines, -225 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

GvR

Hey guys, we're about to release a new version of App Engine (1.2.3) which includes ...

16 years, 12 months ago (2009-06-18 20:34:30 UTC) #1

JohnA

yay, that's good news. lgtm and yes we can delete rietveld.py, it's not needed anymore.

16 years, 12 months ago (2009-06-18 20:45:47 UTC) #2

Andi Albrecht

LGTM! It's great to see that Django 1.x is now supported by App Engine directly! ...

16 years, 11 months ago (2009-06-19 04:04:57 UTC) #3

GvR

16 years, 11 months ago (2009-06-19 18:21:52 UTC) #4

Submitting... Making live...

http://3.latest.codereview.appspot.com/78046/diff/9/1017
File README (right):

http://3.latest.codereview.appspot.com/78046/diff/9/1017#newcode49
Line 49: command line.  To install Django into the correct Python version, you
On 2009/06/19 04:04:58, Andi Albrecht wrote:
> Duplicate whitespace.

Actually it's an old habit that is used (mostly) consistently in this file --
double the space after a sentence-ending period. The reflow command in Emacs
treats this special.

Expand All Messages | Collapse All Messages